wine-devel

wine-devel@winehq.org

3 participants
84490 discussions

Languages/Locales
by steve.lustbader＠philips.com 08 Oct '02

08 Oct '02

ChangeLog (memory/codepage.c): Implement GetUserDefaultUILanguage Implement GetSystemDefaultUILanguage I implemented these functions in codepage.c since similar functions (GetDefaultLangID and GetDefaultLCID) were already there. Why are these functions in this file, instead of in dlls/kernel/locale.c? It seems locales and languages aren't really implemented yet (just hardcoded to English) - is this going in for 1.0 or is it not planned for the immediate future? -Steve (See attached file: patch.diff)

4 3

Re: Listview L10
by Paul Rupe 08 Oct '02

08 Oct '02

On 07 Oct 2002, dpaun(a)rogers.com wrote: > This one fixes a lot of nasty bugs. It also fixes Xnews, > among other things. Yeah, it works great now. Cool. :) > This one should bring the listview to a decent state. > I am interested to hear about outstanding problems. One thing I noticed is that File Open/Save As dialogs in any app now show only icons (the filenames are all blank). I think this must have happened somewhere in the L-series of patches, but I haven't delved in to figure out which one yet. -- Paul Rupe "She smiled, in the end." p r u p e @ m y r e a l b o x . c o m | Oppose government police-ware on your PC! | Stop the Consumer Broadband and Digital Television Promotion Act! | <http://www.eff.org/alerts/20020322_eff_cbdtpa_alert.html>

3 2

Re: wine/dlls/rpcrt4 Makefile.in rpcrt4.spec rpcrt ...
by Greg Turner 07 Oct '02

07 Oct '02

On Monday 07 October 2002 04:49 pm, Alexandre Julliard wrote: > ChangeSet ID: 5665 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2002/10/07 16:49:49 > > Modified files: > dlls/rpcrt4 : Makefile.in rpcrt4.spec rpcrt4_main.c > Added files: > dlls/rpcrt4 : rpc_binding.c rpc_binding.h > > Log message: > Ove Kaaven <ovek(a)transgaming.com> > Implemented RpcBindingInqObject, RpcBindingSetObject, > RpcBindingVectorFree, RpcBindingToStringBindingA/W, > RpcBindingFromStringBindingA/W, RpcStringBindingParseA/W, > I_RpcBindingSetAsync, RpcStringBindingComposeA/W, RpcBindingFree, > RPCStringFreeW, UUIDHash, UuidToStringW, and associated junk. > > Patch: http://cvs.winehq.com/patch.py?id=5665 > > Old revision New revision Changes Path > 1.8 1.9 +1 -0 wine/dlls/rpcrt4/Makefile.in > 1.19 1.20 +11 -10 wine/dlls/rpcrt4/rpcrt4.spec > 1.29 1.30 +78 -73 wine/dlls/rpcrt4/rpcrt4_main.c > Added 1.1 +0 -0 wine/dlls/rpcrt4/rpc_binding.c > Added 1.1 +0 -0 wine/dlls/rpcrt4/rpc_binding.h Interesting that you unrolled the #define macros in rpc_binding.c. I guess the argument against this is that it creates code duplication. The argument for it is more obvious (reduces insanity). In general, should I avoid submitting patches with big nasty #define's that are really inline functions like this, even at the expense of duplicating some code? Personally, I kind of dislike this sort of thing (big nasty #define's); but I notice that, to an extent, they abound in wine, and I must say that I dislike code duplication almost as much. STL is a good compromise, for C++; but obviously that doesn't help us here in C land (or does it? anyhow, STL is probably not a desirable dependency for wine IMHO). M4 is already a dependency but would be a pretty big break from the current way of doing things... if we're to drag in M4 then we'd might as well rework all of wine to use it in place of the big nasty #defines.... sounds like a miserable and tedious process, and when it's all done, nobody can understand the code (including me, and M4 ignoramus). Ugh. !%&!%& script-soup. When did coding become so much like web-page design? I blame Richard Stallman ;) Rule of thumb: Any program with backquoted backquotes is misdesigned! :) Anyhow, now that I've gotten my bitching and moaning out of the way... let me know if you'd like me to break up #defines like this in future patches and I'll do it. As for the stuff that's already checked in, I'm gonna look at the possibility of dropping some of it into RPCRT4_ functions (/real/ functions) to reduce the duplication. -- gmt "If ye love wealth better than liberty, the tranquility of servitude better than the animating contest of freedom, go home from us in peace. We ask not your counsels or your arms. Crouch down and lick the hands, which feed you. May your chains set lightly upon you, and may posterity forget that ye were our countrymen." -Samuel Adams

2 1

Re: d3d8 patch
by Christian Costa 07 Oct '02

07 Oct '02

Ann and Jason Edmeades wrote: >Changelog: > >o Various fixes, typos corrected and clarifying trace points > >Note I am quickly reaching the end of my ability in this area - This brings >the wine tree up to date with all my changes, so some help from anyone would >be appreciated. There are some 'simple' tutorials type dx8 pgms I just cant >get working and I cant see why - email me if you can help > >Additionally, my understanding is in Windows a HAL lives under direct3d and >earlier directdraw functionality - Does anyone know where the interface is >actually documented? I have had it mentioned to me it would be better to try >to make the functionality more common with direct draw and want to see how >this is done under windows. > >Jason > Jason, The Windows HAL is documented in the DDK (Driver Development Kit). It's a package of 60MBytes or so . You can find it at : http://www.microsoft.com/ddk/ If think (but I'm not sure) the actual HAL is the Win98's one. So you should try the Win98 DDK. It's the one I use. Christian

1 0

Re: Languages/Locales
by steve.lustbader＠philips.com 07 Oct '02

07 Oct '02

Should I resubmit this patch with the my functions moved to locale.c or ole2nls.c? Which one? Alexandre Julliard To: Steve Lustbader/ANR/MS/PHILIPS@AMEC <julliard@winehq cc: wine-devel(a)winehq.com .com> Subject: Re: Languages/Locales Sent by: wine-devel-admin Classification: @winehq.com 10/07/2002 02:02 PM steve.lustbader(a)philips.com writes: > I implemented these functions in codepage.c since similar functions > (GetDefaultLangID and GetDefaultLCID) were already there. Why are > these functions in this file, instead of in dlls/kernel/locale.c? Because they are needed by ntdll. This will be fixed eventually. > It seems locales and languages aren't really implemented yet > (just hardcoded to English) - is this going in for 1.0 or is it not planned > for the immediate future? Most of it is already implemented; the relevant stuff is in dlls/kernel/locale.c and ole/ole2nls.c. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Listview L2
by Paul Rupe 07 Oct '02

07 Oct '02

On 06 Oct 2002, dpaun(a)rogers.com wrote: > Another rounds of cleanups > > ChangeLog > -- Cleanup of the way we maintain/lookup the item count > -- Rename GetItemWidth to CalculateMaxWidth > -- Misc trivial changes. It looks like this one breaks Xnews again. With CVS+L0+L1+L2+my patch, the listviews all display as blank. A later patch adds a missing line "infoPtr->nItemCount = nItems;" in LISTVIEW_SetItemCount. This fixes the display problem, but I am still unable to open any newsgroups. Highlighting one and hitting Enter gives me an error from the app "List index (-1) out of bounds," suggesting that it doesn't know that anything is focused/selected. L0 and L1 appear to be fine, but L2-L8 all have this behavior. -- Paul Rupe "She smiled, in the end." p r u p e @ m y r e a l b o x . c o m | Oppose government police-ware on your PC! | Stop the Consumer Broadband and Digital Television Promotion Act! | <http://www.eff.org/alerts/20020322_eff_cbdtpa_alert.html>

2 1

is it winetest or me?
by György 'Nog' Jeney 07 Oct '02

07 Oct '02

While cominuing on my msvcrt test, I ran accross the following anomily(mabe?). If I have ok(0 == 0, NULL) in my test, then everything works fine, but if I get ok(1 == 0, NULL) then the whole thing crashes with an exection to a write error. Anyone have any ides? nog.

2 1

is winemaker working?
by Michael Cardenas 07 Oct '02

07 Oct '02

Hello all. I'm trying to compile a number of winelib programs that are part of the lindows-wine package. To do so, I removed all the makefiles and make.rules files and configure files, and ran winemaker --cuiexe . from the directories containing the source for runonce, geticon, and initcache. The resulting makefiles did compile, after changing the install target to strip the .exe off of the names, but the applications do not run. They look for <appname>.exe in C:\windows\system, but even if I put the apps in that dir with that name, they still don't run and complain tht they can't find <appname>.exe So, is anyone using winemaker? Has anyone used it to make a simple winelib app recently? Does it still work? There seem to have been a lot of changes to the spec file format recently, which have probably rendered it unusable. thanks michael -- michael cardenas | lead software engineer lindows.com hyperpoem.net | GNU/Linux software developer debian.org "What the poet is looking for is not the fundamental I but the deep you." - Antonio Machado

3 2

Re: DOS DPMI32, interrupt handlers in 32-bit code
by Sylvain Petreolle 07 Oct '02

07 Oct '02

Hi Jukka, I tried your patch on the latest CVS. This doesn't compile at the moment, complaining about FARPROC48 : gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -mpreferred-stack-boundary=2 -fPIC -D__WINE__ -D_NTSYSTEM_ -DBINDIR="\"/usr/local/bin\"" -DETCDIR="\"/usr/local/etc\"" -D_REENTRANT -o ../../memory/instr.o ../../memory/instr.c../../memory/instr.c: In function `INSTR_EmulateInstruction': ../../memory/instr.c:689: `FARPROC48' undeclared (first use in this function) ../../memory/instr.c:689: (Each undeclared identifier is reported only once ../../memory/instr.c:689: for each function it appears in.) ../../memory/instr.c:689: parse error before "addr" ../../memory/instr.c:697: `addr' undeclared (first use in this function) make[2]: *** [../../memory/instr.o] Erreur 1 ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

2 2

Re: How to add a new test dir? (Update)
by Greg Turner 07 Oct '02

07 Oct '02

On Sunday 06 October 2002 06:25 pm, Greg Turner wrote: > I'm trying to create a tests directory for rpcrt4. So far I've > done the following: > > o Create a dlls/rpcrt4/tests directory > > o Change dlls/rpcrt4/Makefile.in: > > o add dlls/rpcrt4/tests/Makefile.in: > > o add dlls/rpcrt4/tests/rpc.c: > > but I get no love. configure seems to go OK; > When I run make depend it fails: > > <============== > make[2]: Entering directory `/var/src/wine/dlls/rpcrt4' > cd `dirname tests/__depend__` && make depend > make[3]: Entering directory `/var/src/wine/dlls/rpcrt4/tests' > make[3]: *** No rule to make target `depend'. Stop. > make[3]: Leaving directory `/var/src/wine/dlls/rpcrt4/tests' > make[2]: *** [tests/__depend__] Error 2 > make[2]: Leaving directory `/var/src/wine/dlls/rpcrt4' > make[1]: *** [rpcrt4/__depend__] Error 2 > make[1]: Leaving directory `/var/src/wine/dlls' > make: *** [dlls/__depend__] Error 2 > ==============> > > What am I missing? Is this documented somewhere? > Thanks, I found it: Index: configure.ac =================================================================== RCS file: /home/wine/wine/configure.ac,v retrieving revision 1.81 diff -u -r1.81 configure.ac --- configure.ac 2 Oct 2002 19:58:27 -0000 1.81 +++ configure.ac 7 Oct 2002 03:09:02 -0000 @@ -1435,6 +1435,7 @@ dlls/rasapi32/Makefile dlls/richedit/Makefile dlls/rpcrt4/Makefile +dlls/rpcrt4/tests/Makefile dlls/serialui/Makefile dlls/setupapi/Makefile dlls/shdocvw/Makefile Now I'm sure it'll get even more confusing ;) -- gmt "If ye love wealth better than liberty, the tranquility of servitude better than the animating contest of freedom, go home from us in peace. We ask not your counsels or your arms. Crouch down and lick the hands, which feed you. May your chains set lightly upon you, and may posterity forget that ye were our countrymen." -Samuel Adams

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel