wine-devel

wine-devel@winehq.org

84463 discussions

Tagging releases
by Shachar Shemesh 13 Sep '02

13 Sep '02

Hi, Would it be possible to tag each "release" announced to wine-announce in the CVS, so cvs co -r WINE_20020702 wine will actually get the wine version that corresponds to that release? I know I can do "cvs co -D 2002-jul-02 wine" for similar effect, but I don't like that solution. It has not worked well for me, and it leaves some inclarities regarding files that had several commits on the same day (not to mention time zones etc.) Shachar

2 1

Re: Fix lossage due to pathname truncation in calls to MODULE_LoadLibraryExA
by Andreas Mohr 13 Sep '02

13 Sep '02

On Thu, Sep 12, 2002 at 08:38:09PM +1000, Michael Beach wrote: > Recently I've been using WINE to run a Win32 exe which needs to load certain > DLLs which are located in the same directory as the exe. I was most perplexed > when I found that this worked initially, but when I moved the exe and DLLs to > a different directory it stopped working ie WINE would refuse to start the > exe, claiming that it was unable to load the required DLLs. > > After some debugging, I discovered that the critical factor was the length of > the pathname to the exe, when it passed a certain length it stopped working. > However this length was way short of the MAX_PATH value of 260. Ah, cool finding ! > static BOOL DIR_TryModulePath( LPCWSTR name, DOS_FULL_NAME *full_name, BOOL win32 ) > { > - /* FIXME: for now, GetModuleFileNameW can't return more */ > - /* than OFS_MAXPATHNAME. This may change with Win32. */ > - WCHAR bufferW[OFS_MAXPATHNAME]; > + WCHAR bufferW[MAX_PATH]; > LPWSTR p; > > if (!win32) > @@ -727,13 +725,13 @@ > if (!GetCurrentTask()) return FALSE; > if (!GetModuleFileName16( GetCurrentTask(), buffer, sizeof(buffer) )) > return FALSE; > - MultiByteToWideChar(CP_ACP, 0, buffer, -1, bufferW, OFS_MAXPATHNAME); > + MultiByteToWideChar(CP_ACP, 0, buffer, -1, bufferW, MAX_PATH); > } else { > - if (!GetModuleFileNameW( 0, bufferW, OFS_MAXPATHNAME ) ) > + if (!GetModuleFileNameW( 0, bufferW, MAX_PATH ) ) > return FALSE; > } > if (!(p = strrchrW( bufferW, '\\' ))) return FALSE; > - if (OFS_MAXPATHNAME - (++p - bufferW) <= strlenW(name)) return FALSE; > + if (MAX_PATH - (++p - bufferW) <= strlenW(name)) return FALSE; > strcpyW( p, name ); > return DOSFS_GetFullName( bufferW, TRUE, full_name ); Argl, why does this code use the buffer size contants instead of sizeof(variable) !? I suggest we always specify buffer length constants only *once*, namely at creation of the buffer. Not doing so can be potentially very harmful if we decide to change the buffer length and then manage to forget one or more length constants... Maybe you could even also fix that "weirdness" in our code ? Thanks ! :) -- The Declaration of Software Freedom: http://freedevelopers.net/freedomdec/index.php

4 8

Re: WineLib and DLLs
by steve.lustbader＠philips.com 13 Sep '02

13 Sep '02

If possible, I don't want to insert it into the wine tree, I want to leave it in the source tree of my program. Is including it in the wine tree the only way to link with it? -Steve Jon Griffiths <jon_p_griffiths To: Steven Edwards <steven_ed4153(a)yahoo.com> @yahoo.com> cc: wine-devel(a)winehq.com Sent by: (bcc: Steve Lustbader/ANR/MS/PHILIPS) wine-devel-admin Subject: Re: WineLib and DLLs @winehq.com Classification: 09/12/2002 05:58 PM Please respond to jon_p_griffiths Hi, >I'm writing a WineLib DLL that makes calls in my own Windows DLLs >(not Wine's DLLs). I have the header files for those DLLs, and the >Windows binaries for them. How do I link to them? Do I need to wrap >them in spec files? What do I need to put into my Makefile.in? look at tools/winedump. In spec mode it will generate everything you need to link to this dll - a makefile and dummy implementation, spec file and a script to insert it into your existing WINE tree (to link with). The README gives instructions for exactly this case (and some other more advanced ones). Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________________________ Do you Yahoo!? Yahoo! News - Today's headlines http://news.yahoo.com

2 1

re: shlwapi failes to build on windows
by Jon Griffiths 12 Sep '02

12 Sep '02

Hi, >shlwapi.exp(.edata+0x34):fake: undefined reference to >`AssocCreate@12' >C:\mingw\bin\dllwrap.exe: C:\mingw\bin\gcc exited with status 1 >make: *** [shlwapi.dll] Error 1 >The def should contain AssocCreate@24 I do not know what is needed >in the *.spec though This is due to the spec entry possibly being incorrect. AssocCreate takes a CLSID as its first parameter (rather than a ptr to one as any sane coder would have expected). I have no idea how to tell the spec file that the first parameter is a structure, however this obviously means that the size of the parameters listed after the '@' is wrong. I'm not sure how to fix this, since passing structs is a rare case, I've never looked into how to specify them in the spec. Maybe we need a "struct(n)" spec type for by value structures? Another note: if you're planning to try to test SHLWAPI under Windows you should be running NT 4 or later, as there are some changes needed w.r.t unicode to get earlier O/Ss working OK. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________________________ Do you Yahoo!? Yahoo! News - Today's headlines http://news.yahoo.com

2 2

Fwd: Message Undeliverable
by Dimitrie O. Paun 12 Sep '02

12 Sep '02

This is the second (and I have a third now) message of this type that I receive, even though it seems that my messages to reach the list. What's up? ---------- Forwarded Message ---------- Subject: Message Undeliverable Date: Thu, 12 Sep 2002 15:40:19 -0600 From: postmaster(a)www.praize.com To: dpaun(a)rogers.com User does not exist Message Headers: Return-Path: <wine-patches-admin(a)winehq.com> Received: from admin.praize.com (root@localhost) by praize.com (8.11.6/8.11.6) with ESMTP id g8CLcxP18778 for <gboutwel(a)praize.com>; Thu, 12 Sep 2002 15:38:59 -0600 X-ClientAddr: 198.144.4.3 Received: from wine.codeweavers.com (wine.codeweavers.com [198.144.4.3]) by admin.praize.com (8.11.6/8.11.6) with ESMTP id g8CLcwD18774 for <gboutwel(a)praize.com>; Thu, 12 Sep 2002 15:38:58 -0600 Received: from localhost.localdomain (wine [127.0.0.1]) by wine.codeweavers.com (8.11.6/8.11.6) with ESMTP id g8CLb6F27723; Thu, 12 Sep 2002 16:37:06 -0500 Received: from fep04-mail.bloor.is.net.cable.rogers.com (fep04-mail.bloor.is.net.cable.rogers.com [66.185.86.74]) by wine.codeweavers.com (8.11.6/8.11.6) with ESMTP id g8CLaeF27686 for <wine-patches(a)winehq.com>; Thu, 12 Sep 2002 16:36:41 -0500 Received: from dimi.dssd.ca ([24.103.156.204]) by fep04-mail.bloor.is.net.cable.rogers.com (InterMail vM.5.01.05.06 201-253-122-126-106-20020509) with ESMTP id <20020912213628.FCWQ389684.fep04-mail.bloor.is.net.cable.rogers.com(a)dimi.dss d.ca> for <wine-patches(a)winehq.com>; Thu, 12 Sep 2002 17:36:28 -0400 Content-Type: text/plain; charset="us-ascii" From: "Dimitrie O. Paun" <dpaun(a)rogers.com> Organization: DSSD Software Inc. To: Wine Patches <wine-patches(a)winehq.com> Subject: Trackbar updates User-Agent: KMail/1.4.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <200209121734.32094.dpaun(a)rogers.com> X-Authentication-Info: Submitted using SMTP AUTH LOGIN at fep04-mail.bloor.is.net.cable.rogers.com from [24.103.156.204] using ID <dpaun(a)rogers.com> at Thu, 12 Sep 2002 17:36:27 -0400 Sender: wine-patches-admin(a)winehq.com Errors-To: wine-patches-admin(a)winehq.com X-BeenThere: wine-patches(a)winehq.com X-Mailman-Version: 2.0 Precedence: bulk Reply-To: wine-devel(a)winehq.com X-Reply-To: dpaun(a)rogers.com List-Help: <mailto:wine-patches-request@winehq.com?subject=help> List-Post: <mailto:wine-patches@winehq.com> List-Subscribe: <http://www.winehq.com/mailman/listinfo/wine-patches>, <mailto:wine-patches-request@winehq.com?subject=subscribe> List-Id: Wine Patch Submissions <wine-patches.winehq.com> List-Unsubscribe: <http://www.winehq.com/mailman/listinfo/wine-patches>, <mailto:wine-patches-request@winehq.com?subject=unsubscribe> List-Archive: <http://www.winehq.com/hypermail/wine-patches/> Date: Thu, 12 Sep 2002 17:34:31 -0400 Status: ------------------------------------------------------- -- Dimi.

2 1

Re: WineLib and DLLs
by Jon Griffiths 12 Sep '02

12 Sep '02

Hi, >I'm writing a WineLib DLL that makes calls in my own Windows DLLs >(not Wine's DLLs). I have the header files for those DLLs, and the >Windows binaries for them. How do I link to them? Do I need to wrap >them in spec files? What do I need to put into my Makefile.in? look at tools/winedump. In spec mode it will generate everything you need to link to this dll - a makefile and dummy implementation, spec file and a script to insert it into your existing WINE tree (to link with). The README gives instructions for exactly this case (and some other more advanced ones). Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________________________ Do you Yahoo!? Yahoo! News - Today's headlines http://news.yahoo.com

1 0

Re: SHLWAPI merging #4
by Alexandre Julliard 12 Sep '02

12 Sep '02

Jon <jon_p_griffiths(a)yahoo.com> writes: > Does anyone object to my moving SHLWAPI_1 & 2 into url.c and moving out the > definitions from ordinal.h in there as well? > > I want to tidy this up because at some point in the not too distant future the > ordinal code will get a lot bigger. So it makes sense to me to implement > ordinals that are related in the same files (like the MIME ord. functions in > url.c), and to split out other ord. groups (gdi/windows/com/ie/perfmon etc) > into their own files as well. OK? Actually there's no reason at all to group ordinal functions together, the fact that they are exported by ordinal is just a detail that doesn't matter for understanding what's going on. It's much better to group ordinal string functions with other string functions, ordinal URL functions with other URL stuff etc. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: WineLib and DLLs
by steve.lustbader＠philips.com 12 Sep '02

12 Sep '02

I also have the .lib and .pdb files for the DLLs, if that helps. I'm writing a WineLib DLL that makes calls in my own Windows DLLs (not Wine's DLLs). I have the header files for those DLLs, and the Windows binaries for them. How do I link to them? Do I need to wrap them in spec files? What do I need to put into my Makefile.in? There are instructions in the WineLib docs about binary DLLs, but they seem to be talking about pretending a Linux library is a DLL, which is not what I want to do. -Steve

1 0

WineLib and DLLs
by steve.lustbader＠philips.com 12 Sep '02

12 Sep '02

I'm writing a WineLib DLL that makes calls in my own Windows DLLs (not Wine's DLLs). I have the header files for those DLLs, and the Windows binaries for them. How do I link to them? Do I need to wrap them in spec files? What do I need to put into my Makefile.in? There are instructions in the WineLib docs about binary DLLs, but they seem to be talking about pretending a Linux library is a DLL, which is not what I want to do. -Steve

1 0

Re: Unicode functions
by steve.lustbader＠philips.com 12 Sep '02

12 Sep '02

Thanks, that worked! Do you think you could update the Unicode section in the WineLib user's guide (section 2.2)? It doesn't even mention WINE_UNICODE_NATIVE (not like the rest of the guide is that current, but every little bit helps for new developers). -Steve On Thu, 12 Sep 2002 steve.lustbader(a)philips.com wrote: > I think there is issue with _T(x). I have this line in my Windows app > that I'm compiling with WineLib (I'm using -fshort-wchar): > > const TCHAR *Name() const { return _T("my_name"); }; > > The compiler gives me an error of: > > cannot convert `const __wchar_t *' to `const > TCHAR *' in return If you are using --fshort-wchar you should also use WINE_UNICODE_NATIVE so that WCHAR gets defined to wchar_t. From winnt.h: #ifdef WINE_UNICODE_NATIVE typedef wchar_t WCHAR, *PWCHAR; #else typedef unsigned short WCHAR, *PWCHAR; #endif and further down: /* Define WINE_UNICODE_NATIVE if: * - your compiler provides a 16bit wchar_t type, e.g. gcc >= 2.96 with * -fshort-wchar option * - or if you decide to use the native 32bit Unix wchar_t type. Be aware * though that the Wine APIs only support 16bit WCHAR characters for * binary compatibility reasons. * - or define nothing at all if you don't use Unicode, and blissfully * ignore the issue :-) */ Does that help? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel