wine-devel

wine-devel@winehq.org

7 participants
84405 discussions

what's with WS_OVERLAPPED?
by Medland, Bill 14 Aug '02

14 Aug '02

(Regarding the whole issue of windows reparenting) MSDN keeps going on about windows with the WS_OVERLAPPED style. However surely (since WS_OVERLAPPED=0) every window has such a style these days. Is there something I don't understand? Bill

2 1

Re: RESUBMIT: Quicken 2000 bug/Category blanking => Wine patch
by Dimitrie O. Paun 14 Aug '02

14 Aug '02

On August 14, 2002 01:53 pm, Carl Sopchak wrote: > It was suggested to me that I should not use strlen(), since I'm not > positive if the string will ever really terminate (which may cause a seg > fault), so I programmed my own scan for a null character.. > > Here's the revised patch (attached). What about this: --- controls/edit.c 13 Jun 2002 19:20:43 -0000 1.95 +++ controls/edit.c 14 Aug 2002 17:49:13 -0000 @@ -3957,20 +3957,25 @@ */ static INT EDIT_WM_GetText(EDITSTATE *es, INT count, LPARAM lParam, BOOL unicode) { + INT ii; + if(!count) return 0; if(unicode) { LPWSTR textW = (LPWSTR)lParam; strncpyW(textW, es->text, count); - textW[count - 1] = 0; /* ensure 0 termination */ + for (ii = 0; (ii < count) & textW[ii]; i++) ; + textW[ii - 1] = 0; /* force 0 termination */ return strlenW(textW); } else { LPSTR textA = (LPSTR)lParam; WideCharToMultiByte(CP_ACP, 0, es->text, -1, textA, count, NULL, NULL); - textA[count - 1] = 0; /* ensure 0 termination */ + for (ii = 0; (ii < count) & textA[ii]; i++) ; + textA[ii - 1] = 0; /* force 0 termination */ return strlen(textA); } } Untested :) -- Dimi.

1 0

Am I the only one getting replies from RealNetworks?
by Medland, Bill 14 Aug '02

14 Aug '02

I am getting messages from RealNetworks corresponding to each of my posts to wine-devel. I presume "Mysore Jaisimha" is on the mailing list but no longer works there. Can we do anything about it or do I just throw the messages away? Bill

2 1

RE: Re:can windows be reparented?
by Medland, Bill 14 Aug '02

14 Aug '02

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry@baikal.ru] > Sent: Wednesday, August 14, 2002 9:34 AM > To: Medland, Bill > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > > > keep cc'ing wine-devel please Sorry; I just realised. It's the way I have Outlook set up; I get confused. > > "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > > > Could you please test patch posted by Bill Medland to > > > wine-patches today? It's > > > not entirely correct though. My tests show that > > > SetWindowLong(GWL_HWNDPARENT) > > > call changes simultaneously both parent and owner for top > > > level windows and > > > returns old value (not sure old owner or parent it is). > > > > Even if the window is not in fact a child? > > Yes. According to my test program. > > > Please excuse my ignorance here; > > I am still a little shaky on terminology. Surely if it is > a top level > > window then its parent is the desktop and always will be. > > > > Or are you saying that it reparents to the desktop (and so > the problem is > > down in the SetParent code)? > > I don't see a reparenting to desktop in the relay trace. > > > > But top level windows created by Visual Vasic are special: > > > they have no parent, > > > but only owner according to Spy++. In my tests I can't > > > reproduce it yet. > > > > So you suspect that Spy++ is not telling the truth? (It > wouldn't be the > > first time) > > I incline to trust Spy++ here. It correctly shows paerent/owner for my > test application playing with SetParent/SetWindowLong. It seems that > Windows always sets 0 in the parent field if the parent is > desktop. Even > after explicit SetParent(GetDesktopWindow()) or > SetWindowLong(GWL_HWNDPARENT, > GetDesktopWindow()) GetWindowLong(GWL_HWNDPARENT)/GetWindow(GW_OWNER) > return 0 in my tests. > > > > A bit of investigation of Wine source revealed that some > places use > > > GetAncestor(hwnd, GA_PARENT), while others use GetParent(hwnd). > > > > And, in the case of WIN_CreateWindowEx, GetAncestor (hwnd, GA_ROOT) > > > > > Since > > > their behaviour is different in respect of top level and > > > child windows, > > > some major clean up in that area in Wine is needed. > > > > Careful. > > > > In our particular case, according to Spy++ the owner of the > ThunderRT6FormDC > > is a third-generation window. viz. the actual window > requested, not one of > > its ancestors. > > > > i.e. I see the call to SetWindowLong (30056 (The > ThunderRT6FormDC), -8, > > 10046 (The ThunderRT6UserControlDC)) > > > > I guess an important point here is that in our case the > Visual Basic is an > > OCX sitting inside a container and so the > ThunderRT6UserControlDC is not > > first generation. > > Now I don't understand your terminology. parent - child - sibling are > the termings in the Windows world. Who of them was born > earlier matters > only when Z order and visibility are taken into account (and > can be easily > changed). Sorry; I am being unclear. I mean that (statically, according to Spy++, when the popup form is active) 1. The ThunderRT6FormDC which "is" the form has style WS_OVERLAPPED, no parent (i.e. the desktop) and owner is the ThunderRT6UserControlDC 2. The ThunderRT6UserControlDC which, I believe, "is" the ocx, has style WS_OVERLAPPED and no owner, but its parent is an ATL window 3. That ATL window's parent is another ATL window 4. That second ATL window has no parent. (So, by generations I am talking about the static parent relationship, independent of how it came to be; c.f. old people adopting young ones resulting in skipped generations) > > -- > Dmitry. > > > And I have just noticed the lie in MSDN. It says (Platform SDK - Windows User Interface - Owned windows) that once the window has been created, with an owner, you cannot change the owner. That has to be wrong. A propos. I think there is a related error in CreateWindowEx. At least it disagrees with MSDN. If passed a parent If this is a child set parent to the paremt passed in and leave the owner 0 else set the parent to the desktop and the owner to the GA_ROOT ancestor of the window passed in. Surely it should be (according to MSDN) if passed a parent if style includes WS_OVERLAPPED or WS_POPUP assert style does not include WS_CHILD if the parent is itself WS_OVERLAPPED or WS_POPUP parent is desktop and owner is the parent passed in else if the parent is a WS_CHILD then parent is desktop and owner is the GetAncestor(parent, GA_ROOT) else assert false? else assert WS_CHILD owner is 0 and parent is as specified Comments? One datum of use. In our particular case this fits; the ThunderRT6FormDC is WS_OVERLAPPED with no parent. Its owner is the ThunderRT6UserControlDC which also is WS_OVERLAPPED but has a parent. Bill

1 0

Re: CVS not building?
by jhurst＠ii.net 14 Aug '02

14 Aug '02

I'm *really* sorry about the multiple messages! :( It seemed I jumped the gun and a manual removal of what i thought were problematic .o files did not resolve my build error! :( -jan On Thu, 2002-08-15 at 00:54, jhurst(a)ii.net wrote: > Hello, > > I just updated my CVS tree, and as several files seemed to have been > updated since my last CVS update I attempted to build a new wine. The > build fails with the error attached below. > > My questions are: > > 1. what is the "correct" way to (re)build wine when an existing wine has > previously been built? I have used ./tools/wineinstall previously (and > the attached error is a result). Is this correct? > > 2. Is there a problem with the files I have just pulled from CVS or have > I broken something on this end?! > > Regards, > > -jan > jhurst(a)ii.net > > --> snip <-- > make[2]: Entering directory `/usr/src/wine/dlls/urlmon' > LD_LIBRARY_PATH="../../library:../../unicode:$LD_LIBRARY_PATH" > ../../tools/winebuild/winebuild -fPIC -D__WINE__ -o urlmon.spec.c -spec > ./urlmon.spec urlmon.dll.tmp.o -L../../dlls -lole32 -lwininet -luser32 > -lkernel32 > ./urlmon.spec:1: could not open .so file for wininet.dll > make[2]: *** [urlmon.spec.c] Error 1 > make[2]: Leaving directory `/usr/src/wine/dlls/urlmon' > make[1]: *** [urlmon] Error 2 > make[1]: Leaving directory `/usr/src/wine/dlls' > make: *** [dlls] Error 2 > --> snip <--

1 0

Re: CVS not building?
by jhurst＠ii.net 14 Aug '02

14 Aug '02

My apologies. It seems make clean did not remove some .o files. Manual removal has allowed me to continue the build process. However, can someone please answer my first question? Regards, -jan On Thu, 2002-08-15 at 00:54, jhurst(a)ii.net wrote: > Hello, > > I just updated my CVS tree, and as several files seemed to have been > updated since my last CVS update I attempted to build a new wine. The > build fails with the error attached below. > > My questions are: > > 1. what is the "correct" way to (re)build wine when an existing wine has > previously been built? I have used ./tools/wineinstall previously (and > the attached error is a result). Is this correct? > > 2. Is there a problem with the files I have just pulled from CVS or have > I broken something on this end?! > > Regards, > > -jan > jhurst(a)ii.net > > --> snip <-- > make[2]: Entering directory `/usr/src/wine/dlls/urlmon' > LD_LIBRARY_PATH="../../library:../../unicode:$LD_LIBRARY_PATH" > ../../tools/winebuild/winebuild -fPIC -D__WINE__ -o urlmon.spec.c -spec > ./urlmon.spec urlmon.dll.tmp.o -L../../dlls -lole32 -lwininet -luser32 > -lkernel32 > ./urlmon.spec:1: could not open .so file for wininet.dll > make[2]: *** [urlmon.spec.c] Error 1 > make[2]: Leaving directory `/usr/src/wine/dlls/urlmon' > make[1]: *** [urlmon] Error 2 > make[1]: Leaving directory `/usr/src/wine/dlls' > make: *** [dlls] Error 2 > --> snip <--

1 0

Re: Re:can windows be reparented?
by Dmitry Timoshkov 14 Aug '02

14 Aug '02

keep cc'ing wine-devel please "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > Could you please test patch posted by Bill Medland to > > wine-patches today? It's > > not entirely correct though. My tests show that > > SetWindowLong(GWL_HWNDPARENT) > > call changes simultaneously both parent and owner for top > > level windows and > > returns old value (not sure old owner or parent it is). > > Even if the window is not in fact a child? Yes. According to my test program. > Please excuse my ignorance here; > I am still a little shaky on terminology. Surely if it is a top level > window then its parent is the desktop and always will be. > > Or are you saying that it reparents to the desktop (and so the problem is > down in the SetParent code)? I don't see a reparenting to desktop in the relay trace. > > But top level windows created by Visual Vasic are special: > > they have no parent, > > but only owner according to Spy++. In my tests I can't > > reproduce it yet. > > So you suspect that Spy++ is not telling the truth? (It wouldn't be the > first time) I incline to trust Spy++ here. It correctly shows paerent/owner for my test application playing with SetParent/SetWindowLong. It seems that Windows always sets 0 in the parent field if the parent is desktop. Even after explicit SetParent(GetDesktopWindow()) or SetWindowLong(GWL_HWNDPARENT, GetDesktopWindow()) GetWindowLong(GWL_HWNDPARENT)/GetWindow(GW_OWNER) return 0 in my tests. > > A bit of investigation of Wine source revealed that some places use > > GetAncestor(hwnd, GA_PARENT), while others use GetParent(hwnd). > > And, in the case of WIN_CreateWindowEx, GetAncestor (hwnd, GA_ROOT) > > > Since > > their behaviour is different in respect of top level and > > child windows, > > some major clean up in that area in Wine is needed. > > Careful. > > In our particular case, according to Spy++ the owner of the ThunderRT6FormDC > is a third-generation window. viz. the actual window requested, not one of > its ancestors. > > i.e. I see the call to SetWindowLong (30056 (The ThunderRT6FormDC), -8, > 10046 (The ThunderRT6UserControlDC)) > > I guess an important point here is that in our case the Visual Basic is an > OCX sitting inside a container and so the ThunderRT6UserControlDC is not > first generation. Now I don't understand your terminology. parent - child - sibling are the termings in the Windows world. Who of them was born earlier matters only when Z order and visibility are taken into account (and can be easily changed). -- Dmitry.

1 0

RE: Re:can windows be reparented?
by Medland, Bill 14 Aug '02

14 Aug '02

> -----Original Message----- > From: Dmitry Timoshkov [mailto:dmitry@baikal.ru] > Sent: Tuesday, August 13, 2002 6:33 PM > To: us(a)the-edmeades.demon.co.uk > Cc: wine-devel(a)winehq.com > Subject: Re: Re:can windows be reparented? > > > <us(a)the-edmeades.demon.co.uk> wrote: > > > To be honest I never investigated further once I commented > out the SetParent call, > > as I was continuing to fix oleaut32 and left the gui side > to someone else! > > > > I know it was being called in the failing case, and > removing it allowed the > > windows to pop up, BUT they were still wrong as you could > access the 'parent' > > whereas you should not be able to > > Could you please test patch posted by Bill Medland to > wine-patches today? It's > not entirely correct though. My tests show that > SetWindowLong(GWL_HWNDPARENT) > call changes simultaneously both parent and owner for top > level windows and > returns old value (not sure old owner or parent it is). Even if the window is not in fact a child? Please excuse my ignorance here; I am still a little shaky on terminology. Surely if it is a top level window then its parent is the desktop and always will be. Or are you saying that it reparents to the desktop (and so the problem is down in the SetParent code)? > > But top level windows created by Visual Vasic are special: > they have no parent, > but only owner according to Spy++. In my tests I can't > reproduce it yet. So you suspect that Spy++ is not telling the truth? (It wouldn't be the first time) > > A bit of investigation of Wine source revealed that some places use > GetAncestor(hwnd, GA_PARENT), while others use GetParent(hwnd). And, in the case of WIN_CreateWindowEx, GetAncestor (hwnd, GA_ROOT) > Since > their behaviour is different in respect of top level and > child windows, > some major clean up in that area in Wine is needed. Careful. In our particular case, according to Spy++ the owner of the ThunderRT6FormDC is a third-generation window. viz. the actual window requested, not one of its ancestors. i.e. I see the call to SetWindowLong (30056 (The ThunderRT6FormDC), -8, 10046 (The ThunderRT6UserControlDC)) I guess an important point here is that in our case the Visual Basic is an OCX sitting inside a container and so the ThunderRT6UserControlDC is not first generation. > > -- > Dmitry. > > > > Hope this helps. Bill

1 0

RE: [Help] When one application internally invokes another applic ation?
by Medland, Bill 14 Aug '02

14 Aug '02

I presume that c:\windows is in the path Try using --debugmsg +module to see where it looks for the notepad Bill > -----Original Message----- > From: leanne [mailto:leanne@thizlinux.com] > Sent: Wednesday, August 14, 2002 2:44 AM > To: wine-devel(a)winehq.com; wine-users(a)winehq.com > Subject: [Help] When one application internally invokes another > application? > > > Dear all, > > I wonder wine's config would help if one application needs to invoke > another application, say, Notes Client to > open attachment with notepad.exe. I fail to open the > attached txt file > and it complained no such program. > I have put notepad.exe on /usr/share/wine-c/windows/ and > /usr/share/wine-c/windows/system :-( > > Anyone could help is much appreciated. > > Thanks. > Leanne > >

1 0

sgml
by Fabian Cenedese 14 Aug '02

14 Aug '02

Hi What is the easiest way to view/print the wine-help files that are in sgml? I fiddled around with sgmltools but couldn't get a useful output (I guess I just gave up too early, don't want to consider the other option :). What do others use for viewing them? Thanks Fabi

5 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel