wine-devel

wine-devel@winehq.org

3 participants
84472 discussions

Re: Fix for [bug 829] DIB_DirectDrawSurface_Blt same src./dest. surface = screen corruption
by Lionel Ulmer 03 Jul '02

03 Jul '02

The patch looks fine to me. There is just one comment opn these lines : > + if (SameSurface) > + { > + static BOOL WarnSurface = FALSE; > + if (!WarnSurface) > + { > + FIXME("\tSame source and destination could cause display problems\n"); > + WarnSurface = TRUE; > + } > + } Why did you add this ? If you verified your patch and it's working, why add additionnal debug informations that will only confuse people :-) ? Moreover, I do not know the performance hit between a 'memcpy' and a 'memmove', but well, one could have put the old code in a if (!SameSurface) to have the fastest path available to the most common case. A part from these nitpicks, the patch looks fine and I will test it this evening on FalloutTactics to see if it fixes the screen corruption :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Re: Fix for [bug 829] DIB_DirectDrawSurface_Blt same src./dest. surface = screen corruption
by Ian D. Stewart 03 Jul '02

03 Jul '02

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tuesday 02 July 2002 18:57, Tony Lambregts wrote: > Change log: Fix screen corruption when source and destination are the > same surface and areas are the same size. I've applied this patch. While the on-screen garbage has not entirely gone away, it does appear to be better (but then, it could just be my imagination...). No change to hang-up after playing movies. Ian -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE9Iv8YAjpHQQmBAUMRAtjMAJ0eSyS5Z06Kr51uLloq/Nn9CuKQXwCglPrD Ff3Vfg2m2tcqpA1VkeQI9+0= =IPbG -----END PGP SIGNATURE-----

2 1

Arts, DSound, and Media Player
by Jeremy Shaw 03 Jul '02

03 Jul '02

Hello, I am trying to get media player to work with the winearts audio driver. I compiled the latest source from CVS, added Drivers="winearts.drv" to the config file, and installed media player. When I try to play a file (like an mp3), I do not get any audio. If I watch the elapse time, it will increment normally for a few seconds and then start playing super fast. Also when it starts playing super-fast I get the following error a bunch of times: fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=17640 < primary_done=49392) At this point in time I know very little about what is wrong. Do you guys (we are all guys ???) think it is a problem with the wine source, my build of KDE, or just some messed up config files. Or perhaps I just installed too many native DLLs trying to make media player work? I will keep hacking away, but any guidance will be highly valued. I have not gotten ever gotten sound using the winearts driver, but so far I have only tried media player. Thanks in advance, Jeremy Shaw.

2 1

Re: [help] GDI text fonts
by Huw D M Davies 03 Jul '02

03 Jul '02

On Wed, Jul 03, 2002 at 04:54:18PM +0800, leanne wrote: > Huw D M Davies wrote: > > > > >It's still not clear to me whether you're using XServer rendered fonts > >or client side (Wine) rendered fonts. Could you send me the > >--debugmsg +font,+xrender log ? > > > >Huw. > > > Hello, > > I have checked cvs today and found that it supports to download tt > fonts to printer but the position of the text messes up. > Maybe it's a bug. > > I still find the font of the interface is very ugly, what do you think? > Attached please find the log and screenshot. > Very thanks. > > trace:font:DumpFontList Family: L"AR PL Mingti2L Big5" > trace:font:DumpFontList L"Reguler" > trace:font:DumpFontList Family: L"AR PL KaitiM Big5" > trace:font:DumpFontList L"Regular" There's a problem with Type42 font downloads, a workaround for this to edit generic.ppd and change the line *TTRasterizer: Type42 to *TTRasterizer: None this will tell Wine to send download the font as a Type 1 outline which should work. Do you mean that the roman (English) font is ugly (since I have no idea whether the Chinese characters look ok maybe you let me know how they look)? You only have two fonts installed (see the above fragment from the log), so the english text has to come from one of these fonts. What you may want to do is to install some fonts like Arial, Times New Roman etc. You could either copy these from a Windows installation (or add a line to the [FontDirs] section of config to point at an existing Windows partition font directory), or you can download a selection of the core Windows fonts from Microsoft's website. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Still getting this error
by Steven Edwards 03 Jul '02

03 Jul '02

With the last release I can build and use wine but with the current CVS I still get the following errors. Warning: loading builtin gdi32.dll, but native version already present. Expect trouble. Warning: loading builtin user32.dll, but native version already present. Expect trouble. wine: Unhandled exception, starting debugger... I am still not able to track down the patch that causes this. I have a clean WINE with no windows on any of my drives in my slackware box. Thanks Steven __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

1 1

Re: Private Profile Regression Test
by Dmitry Timoshkov 03 Jul '02

03 Jul '02

"Joshua Thielen" <thielen(a)netprince.net> wrote: > Anyhoo, please let me know what you think - are the tests sufficient, > too much, not written properly? etc. First of all, thank you very much Joshua! Really great work! A couple of comments though: /* * Special case: NULL lpReturnedString with size > 0 * This causes an application error in win2k. Let's make wine better :) */ IMO it's not very good idea to make some tests succeed under Wine, which clearly crashes under win2k. That would play some bad role in the case of the back porting Wine code to Windows, since some code, internal to Wine, could rely on that forbidden API behaviour. I also have the following failures under win2k: Number of bytes read do not match FAIL: c:\result.ini does not match compare1.ini Number of bytes read do not match FAIL: c:\result.ini does not match compare2.ini -- Dmitry.

2 2

Re: Small 'let's prevent a crash' fix
by Lionel Ulmer 02 Jul '02

02 Jul '02

> This does not fix the real problem (ie why does this DC not have a font even > if the application called a 'SelectObject' on it), but well, it cannot harm > to be more verbose and to prevent crashes if possible :-) OK, found the 'error' : the problem comes from the fact that I am using client-side fonts (aka XRender) : so the 'font' part of the physDev structure is always '0'. And that also means that we cannot use as is the glXUseXFont function. So basically, I need to implement it myself using 'GetGlyphOutline' (should not be that hard to do :-) ). Now my question : is 'GetGlyphOutline' always working even when not using client-side fonts ? If yes, I will completely remove the call to glXUseXFonts (I know, in that case, fonts displayed by OpenGL will be different by the one displayed by X, but well, ...) and always use the manual 'GetGlyphOutline' function. And I will try at the same time to remove all GLX calls from wgl.c and put them in special X11DRV escapes to have a real X11 free wgl.c file (ie for example, creating an OpenGL context would be a special escape for the X11DRV as it's basically something that is in GLX). Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Re: Removed extra , from enum declarations
by Andreas Mohr 02 Jul '02

02 Jul '02

On Tue, Jul 02, 2002 at 03:39:04PM -0400, Gregg Mattinson wrote: > Resubmitting because I forgot to attach the file. Sorry. I'm also sorry about > the large number of posts today. You feel sorry about WHAT !? Heck, I guess you might have a minimalistic reason to feel sorry once you manage to crash the mailing list server due to sending way too many patches, but until that happens... ;-) Have a nice day ! -- "My attitude is, everybody should try competing with Microsoft once in their life. Once." - Marc Andreessen, former Netscape lead employee, in a "browser wars" interview

1 0

Re: Added support for APPMODE=<type>[:<mainFunc>]
by Joerg Mayer 02 Jul '02

02 Jul '02

On Tue, Jul 02, 2002 at 04:06:56PM -0400, Gregg Mattinson wrote: > - .spec files can't be compiled with -g when using Forte C. This causes static > variables to have a "random" prefix attached to their name, and prevents the > assembly code from linking to them correctly. > - Forte C has linker issues, so cui executables with main() conflicted with > main() in $WINELOADER. Renaming main() to main2() solved the issue, so I added > support to winebuild to allow the main function name to be optionally specified > in the makefile. > - Forte C does not support .previous It was replaced with a .section statement > for the appropriate section > - '.section .text' is incorrect. It should be '.section ".text"' You omitted: - Replace constants by numeric values (aka magic numbers). > - fprintf( outfile, " rec.code = 0x%08x;\n", EXCEPTION_WINE_STUB ); > + fprintf( outfile, " rec.code = 0x%08x;\n", 0x80000100 ); - Inserted compiler specific compilation (as opposed to feature specific compilation) > +#ifndef __SUNPRO_C > fprintf( outfile, "\n#include \"pshpack1.h\"\n" ); > +#endif - Removed some unneeded includes. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

1 0

Re: Void functions can't return a value
by Joerg Mayer 02 Jul '02

02 Jul '02

On Tue, Jul 02, 2002 at 03:34:44PM -0400, Gregg Mattinson wrote: > - void functions can't return a value, even if it is the return value from > another void function. Just looking at the patch a bit. This looks wrong to me. If you want to make the changes, you should convert return xxx() into { xxx(); return } > void WINAPI PathStripPathAW(LPVOID lpszPath) > { > if (SHELL_OsIsUnicode()) > - return PathStripPathW(lpszPath); > - return PathStripPathA(lpszPath); > + PathStripPathW(lpszPath); > + PathStripPathA(lpszPath); <----- should not be executed if condition is met > } This pattern is repeated several times. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel