wine-devel

wine-devel@winehq.org

2 participants
84488 discussions

Re: wine/ controls/menu.c dlls/commdlg/cdlg32.c dl ...
by Dimitrie O. Paun 17 May '02

17 May '02

On May 16, 2002 10:55 pm, Alexandre Julliard wrote: > > Log message: > Export the debugging API from libwine instead of ntdll. > Removed debugres_[aw]. I think you need to test for null strings in default_dbgstr_[aw]n, no? Also, the default implementations are there for the mingw port? We normally use the ones from NTDLL_dbgstr_*, right? -- Dimi.

2 1

64bit values in API args...
by Vincent Béron 17 May '02

17 May '02

I have a little problem implementing VerifyVersionInfo{A,W}. Here's the prototype of the function (W): BOOL WINAPI VerifyVersionInfoW( LPOSVERSIONINFOEXW lpVersionInfo, DWORD dwTypeMask, DWORDLONG dwlConditionMask) with DWORDLONG being a 64bit value. Now, how do I translate that in kernel32.spec? The current declaration in kernel32.spec is @ stdcall VerifyVersionInfoW(long long long long) VerifyVersionInfoW with either a try to get a "long long" type (undistinguishable from 2 longs), or by just assuming a virtual fourth argument to get the right total argument size. Now, this seems really fishy. I'm not very familiar with the way a C compiler places arguments either in registers or on the stack, but I'm not sure the way it is currently declared is the best way to do it. I'd prefer to define a new type for use in spec files, meaning a 64bit argument. Comments? BTW, for the moment VerifyVersionInfo seems to be the only place in Wine where the DWORDLONG type is used, but that doesn't mean there are no other unimplemented API using it. Vincent

1 0

Component owner for controls
by Andriy Palamarchuk 17 May '02

17 May '02

Does anybody want to voluteer to take ownership over usual controls? I already have owners for common controls Andriy __________________________________________________ Do You Yahoo!? LAUNCH - Your Yahoo! Music Experience http://launch.yahoo.com

2 1

Open watcom
by Uwe Bonnes 17 May '02

17 May '02

Hallo, today, there was an announce of a 0.0.8 release of open watcom on the linux announce newsgroup: http://www.openwatcom.org ftp://ftp.openwatcom.org/watcom/openwatcom Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: Fix to get Unreal Tournament-based installers to work from root of CD
by Alexandre Julliard 17 May '02

17 May '02

Dustin Navea <speeddymon(a)yahoo.com> writes: > Hopefully this doesn't break anything. If it does, I > will attempt to fix the open_winelib_app being called > problem... I may need some help though... The real problem is that for some reason Wine didn't recognize setup.exe as a Window binary. That's what you'll need to fix, your patch is only hiding the problem. -- Alexandre Julliard julliard(a)winehq.com

2 2

Re: wine/dlls/winmm mmsystem.c winemm.h
by Michael Stefaniuc 16 May '02

16 May '02

Hello, tested the patch and FreeSolitaire works again. You can close the bug entry. thanks bye michael On Thu, May 16, 2002 at 10:03:17PM +0200, Eric Pouech wrote: > Eric Pouech a écrit : > oops the last hunk of the patch isn't part of the patch > so Alexandre, please use this file instead > > A+ > Name: ps_a2w > ChangeLog: fixed hangs when playing an ASCII resource > License: X11 > GenDate: 2002/05/16 19:48:36 UTC > ModifiedFiles: dlls/winmm/mmsystem.c > AddedFiles: > =================================================================== > RCS file: /home/cvs/cvsroot/wine/wine/dlls/winmm/mmsystem.c,v > retrieving revision 1.52 > diff -u -u -r1.52 mmsystem.c > --- dlls/winmm/mmsystem.c 12 May 2002 03:10:26 -0000 1.52 > +++ dlls/winmm/mmsystem.c 16 May 2002 19:39:46 -0000 > @@ -447,6 +447,7 @@ > waveOutUnprepareHeader(hWave, &waveHdr[1], sizeof(WAVEHDR)); > > errCleanUp: > + TRACE("Done playing='%s' !\n", debugstr_w(wps->pszSound)); > CloseHandle(s.hEvent); > HeapFree(GetProcessHeap(), 0, waveHdr); > HeapFree(GetProcessHeap(), 0, lpWaveFormat); > @@ -463,6 +464,21 @@ > return bRet; > } > > +static BOOL MULTIMEDIA_IsString(DWORD fdwSound, const void* psz) > +{ > + /* SND_RESOURCE is 0x40004 while > + * SND_MEMORY is 0x00004 > + */ > + switch (fdwSound & SND_RESOURCE) > + { > + case SND_RESOURCE: return HIWORD(psz) != 0; /* by name or by ID ? */ > + case SND_MEMORY: return FALSE; > + /* any other case (SND_ALIAS, SND_FILENAME... shall drop into this one) */ > + case 0: return TRUE; > + default: FIXME("WTF\n"); return FALSE; > + } > +} > + > static BOOL MULTIMEDIA_PlaySound(LPCWSTR pszSound, HMODULE hmod, DWORD fdwSound, DWORD search) > { > WINE_PLAYSOUND* wps = NULL; > @@ -515,10 +531,9 @@ > } while (InterlockedCompareExchangePointer((void**)&iData->lpPlaySound, wps, NULL) != NULL); > > if (fdwSound & SND_ASYNC) { > - if (!((fdwSound & SND_MEMORY) || ((fdwSound & SND_RESOURCE) && > - !((DWORD)pszSound >> 16)) || > - !pszSound)) { > - wps->pszSound = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(pszSound)+1) * sizeof(WCHAR) ); > + if (MULTIMEDIA_IsString(fdwSound, pszSound)) > + { > + wps->pszSound = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(pszSound)+1) * sizeof(WCHAR)); > lstrcpyW((LPWSTR)wps->pszSound, pszSound); > } > wps->bLoop = fdwSound & SND_LOOP; > @@ -541,16 +556,13 @@ > { > LPWSTR pszSoundW; > BOOL bSound; > + > + pszSoundW = (MULTIMEDIA_IsString(fdwSound, pszSoundA)) ? > + HEAP_strdupAtoW(GetProcessHeap(), 0, pszSoundA) : (LPWSTR)pszSoundA; > > - if (!((fdwSound & SND_MEMORY) || > - ((fdwSound & SND_RESOURCE) && !((DWORD)pszSoundA >> 16)) || > - !pszSoundA)) { > - pszSoundW = HEAP_strdupAtoW(GetProcessHeap(), 0, pszSoundA); > - bSound = PlaySoundW(pszSoundW, hmod, fdwSound); > - HeapFree(GetProcessHeap(), 0, pszSoundW); > - } else > - bSound = PlaySoundW((LPWSTR)pszSoundA, hmod, fdwSound); > - > + bSound = PlaySoundW(pszSoundW, hmod, fdwSound); > + if ((void*)pszSoundW != (void*)pszSoundA) HeapFree(GetProcessHeap(), 0, pszSoundW); > + > return bSound; > } > > @@ -585,14 +597,12 @@ > LPWSTR pszSoundW; > BOOL bSound; > > - if (!((uFlags & SND_MEMORY) || > - ((uFlags & SND_RESOURCE) && !((DWORD)pszSoundA >> 16)) || > - !pszSoundA)) { > - pszSoundW = HEAP_strdupAtoW(GetProcessHeap(), 0, pszSoundA); > - bSound = sndPlaySoundW(pszSoundW, uFlags); > + pszSoundW = (MULTIMEDIA_IsString(uFlags, pszSoundA)) ? > + HEAP_strdupAtoW(GetProcessHeap(), 0, pszSoundA) : (LPWSTR)pszSoundA; > + > + bSound = sndPlaySoundW(pszSoundW, uFlags); > + if ((void*)pszSoundW != (void*)pszSoundA) > HeapFree(GetProcessHeap(), 0, pszSoundW); > - } else > - bSound = sndPlaySoundW((LPWSTR)pszSoundA, uFlags); > > return bSound; > } -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

winedefault.reg and .Default user entries
by Sylvain Petreolle 16 May '02

16 May '02

Hi, Looking at recent patches, I saw entries for the user .Default in winedefault.reg. Are these entries useful ? I think not because wine uses the real username to load registry entries from the $HOME/.wine/user.reg. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: wine-20020509/dlls/winsock/socket.c
by Francois Gouget 16 May '02

16 May '02

Please, see Warren Baird's (Warren_Baird(a)cimmetry.com) patch on this and my reply to wine-devel. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ If it stinks, it's chemistry. If it moves, it's biology. If it does not work, It's computer science.

1 0

Re: Patch - check for msghdr.msg_control on Sparc-Solaris
by Francois Gouget 16 May '02

16 May '02

On Thu, 16 May 2002 Warren_Baird(a)cimmetry.com wrote: > > > > ChangeLog: > > - added a test for the msg_control field in struct msghdr > (does't appear in sparc-solaris) I think it would be better to do it using a technique similar to how it is done in scheduler/client.c on line 255: #ifdef HAVE_MSGHDR_ACCRIGHTS msghdr.msg_accrights = (void *)&fd; msghdr.msg_accrightslen = sizeof(fd); #else /* HAVE_MSGHDR_ACCRIGHTS */ cmsg.len = sizeof(cmsg); cmsg.level = SOL_SOCKET; cmsg.type = SCM_RIGHTS; cmsg.fd = fd; msghdr.msg_control = &cmsg; msghdr.msg_controllen = sizeof(cmsg); msghdr.msg_flags = 0; #endif /* HAVE_MSGHDR_ACCRIGHTS */ -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Dieu dit: "M-x Lumière". Et la lumière fut.

1 0

Re: wine/programs/winetest wtmain.c
by Dimitrie O. Paun 16 May '02

16 May '02

On May 16, 2002 04:32 pm, Alexandre Julliard wrote: > Log message: > Better usage message. Flush stderr before exiting. And I thought stderr was unbuffered... -- Dimi.

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel