wine-devel

wine-devel@winehq.org

12 participants
84441 discussions

Patch series for async socket IO & winsock2
by Martin Wilck 15 Apr '02

15 Apr '02

Hi, I will soon start submitting this week's work on async sockets. As I said in yesterday's "good news/bad news" posting, this is work in progress and far from being complete. However, I strongly need feedback and perhaps some testing by adventurous people. Anybody out there with an app that uses overlapped socket IO ?? However, the more basic parts can hardly break things, and do represent an improvement against the current CVS version. Even the other parts probably don't break apps, but I have not carried out extensive regression testing so far. Since the full thing would be too big, I have splitted it into functional pieces that are easier to read. I will forward those parts that I consider sufficiently robust to wine-patches. Of course the back side of splitting the patches is that the later ones depend (at least some) of the others. I have indicated these dependencies in the headers. That's not beutiful but probably better than one big chunk. I will be extremely grateful for any feedback. Nice weekend, Martin PS: As I indicated in my last posting, there is a lot of work outstanding to make all of the winsock2 code consistent with this async IO implementation. I see strange things in socket.c anyway, e.g. the select() call that simply disregards all the wait mechanisms that are provided in other places in wine. If any of the original authors of this code read this message, I'd be really happy to get in contact with you!! -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck@Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

3 2

Patch: sock-shutdown-file.diff (11 in series)
by Martin Wilck 15 Apr '02

15 Apr '02

Patch: sock-shutdown-file.diff Enables error handling if ReadFile() WriteFile() are called on a socket after the respective channel of the socket was shut down. Patch against: CVS 2002-04-12, with my previously submitted patches applied. Modified files: files: file.c --- TMP/wine/files/file.c Fri Apr 12 11:54:50 2002 +++ MW/wine/files/file.c Fri Apr 12 11:54:28 2002 @@ -1514,6 +1514,16 @@ SetLastError ( ERROR_INVALID_PARAMETER ); return FALSE; } + if ( ! (flags & FD_FLAG_OVERLAPPED) ) { + WARN ( "fd is not overlapped\n" ); + SetLastError ( ERROR_INVALID_PARAMETER ); + goto error; + } + if ( flags & FD_FLAG_RECV_SHUTDOWN ) { + /* Fixme: WSAESHUTDOWN is unavailable */ + SetLastError ( ERROR_BROKEN_PIPE ); + goto error; + } ovp = (async_fileio*) HeapAlloc(GetProcessHeap(), 0, sizeof (async_fileio)); if(!ovp) @@ -1730,6 +1740,16 @@ { TRACE( "Couldn't get FD\n" ); return FALSE; + } + if ( ! (flags & FD_FLAG_OVERLAPPED) ) { + WARN ( "fd is not overlapped\n" ); + SetLastError ( ERROR_INVALID_PARAMETER ); + goto error; + } + if ( flags & FD_FLAG_SEND_SHUTDOWN ) { + /* Fixme: WSAESHUTDOWN is unavailable */ + SetLastError ( ERROR_BROKEN_PIPE ); + goto error; } ovp = (async_fileio*) HeapAlloc(GetProcessHeap(), 0, sizeof (async_fileio));

2 2

Re: Regression tests, UNICODE vs ASCII
by Lina Kemmel 15 Apr '02

15 Apr '02

You can write something like the following: const WCHAR zeroWidthNonJoiner = 0x200C; const WCHAR zeroWidthJoiner = 0x200D; const WCHAR leftToRightMark = 0x200E; const WCHAR rightToLeftMark = 0x200F; const WCHAR leftToRightEmbedding = 0x202A; const WCHAR rightToLeftEmbedding = 0x202B; const WCHAR popDirectionalFormatting = 0x202C; const WCHAR leftToRightOverride = 0x202D; const WCHAR rightToLeftOverride = 0x202E; ( or enum { zeroWidthNonJoiner = 0x200C, zeroWidthJoiner, leftToRightMark, rightToLeftMark, leftToRightEmbedding = 0x202A, rightToLeftEmbedding, popDirectionalFormatting, leftToRightOverride, rightToLeftOverride }; ) const WCHAR test_string[] = {zeroWidthNonJoiner, zeroWidthJoiner, leftToRightMark, ... , rightToLeftOverride}; Lina Francois Gouget <fgouget(a)free.fr> Sent by: wine-devel-admin(a)winehq.com 14/04/02 10:02 م Please respond to Francois Gouget To: Shachar Shemesh <wine-devel(a)sun.consumer.org.il> cc: Andriy Palamarchuk <apa3a(a)yahoo.com>, Geoffrey Hausheer <i8e7fkwmsl1(a)phracturedblue.com>, <wine-devel(a)winehq.com> Subject: Re: Regression tests, UNICODE vs ASCII On Sun, 14 Apr 2002, Shachar Shemesh wrote: > One thing you may try are the explicit BiDi specifiers (Right to left, > left to right etc.). These are Unicode characters designed to explicitly > specify the direction of otherwise amigious characters. > > Ansii does not have, to the best of my knowledge, an equivalent encoded > characters. But what would these Unicode characters look like? I.e. what would I write in my code: const WCHAR test_string[]={'???','???','???'}; -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

1 0

re: 16-bit apps starting and stopping notification
by Joshua Thielen 15 Apr '02

15 Apr '02

> Can somebody give me a hint how is better to approach > implementation of > NFY_EXITTASK, NFY_STARTTASK events generation? Does anyone know what ToolHelpHook does (KERNEL.341)? Could this be used by windows to hook a toolhelp notification function into kernel.dll? > How important do you think is to implement this > functionality, since it is for 16-bit apps only? I still use a 16-bit app for school that uses these functions and that doesn't work in wine. I'm not sure if the app does't work because it needs these notifications or if there is another reason. I attempted to implement this a couple of months ago, but it was an ugly hack since I was calling a toolhelp helper function from kernel.dll (or maybe it was ntdll) in order to send the notification. Regards, Josh Thielen

2 2

Directory reorganization
by Joshua Thielen 14 Apr '02

14 Apr '02

Hello everybody, I have an idea for reorganizing some of the directories in wine. I hope I'm not stating an obvious idea here, but I would like to group everything into the following first level directories: dlls documentation include programs server tools I'm not sure, but maybe the following directories should also be included: libtest miscemu ole The point is to keep all related source files together with their dll directory. This way, if a new hacker is hunting for a bug, it is clear where they should begin to look. Also, it is easier to focus on the code for one dll this way. Here is where I would move things: controls --> dlls/user/controls files --> dlls/ntdll/files graphics --> dlls/gdi/graphics if1632 --> dlls/ntdll/if1632 library --> dlls (and possibly rename to wine?) loader --> dlls/ntdll/loader memory --> dlls/ntdll/memory msdos --> dlls/ntdll/msdos relay32 --> dlls/ntdll/relay32 scheduler --> dlls/ntdll/scheduler win32 --> dlls/ntdll/win32 windows --> dlls/user/windows These are the directories I'm not sure about: miscemu --> programs (possibly rename to wine?) ole --> dlls/ntdll/ole (ole is also used by library, maybe it should go to dlls/library?) tsx11 --> dlls/tsx11 (or maybe we should have a 'drivers' top-level directory?) graphics/tsx11 --> dlls/tsx11/graphics windows/tsx11 --> dlls/tsx11/windows unicode --> dlls/unicode Please let me know what you think. Thanks, Josh Thielen

2 1

Unknown Windows message number
by ccrayne＠crayne.org 14 Apr '02

14 Apr '02

While testing an application which I have (mostly) running under Wine, I consistently see the following message sent sometines to RICHEDIT32_WindowProc and sometimes to TOOLTIPS_WindowProc: msg: 0xc01e wp: 0 lp: 0x40596d60 Any clues as to what this message is would be welcome. -- Chuck Crayne ----------------------------------------------------------- ccrayne(a)crayne.org -----------------------------------------------------------

3 3

Regression tests, UNICODE vs ASCII
by Geoffrey Hausheer 14 Apr '02

14 Apr '02

So I've finally started writing tests for functions that have both Unicode and Ascii equivalents, and I'm wondering how to write the tests. I re-read the thread about this that occurred back in January, and there didn't seem to be a clear decision. With the current framework, it doesn't appear to be possible to just write one test, and have it build both unicode and ascii versions, and it seems like at least Alexandre was strongly against this anyway. But in my case, I know nothing at all about writing Unicode tests, or how to explicitly test unicode functionality, so I see that I have three options: 1) Don't write any 'W' tests, and use only 'A' functions in my tests 2) Duplicate my 'A' tests as 'W' tests, and acknowledge that there is likely Unicode specific stuff that is not tested 3) Learn something about Unicode, and figure out how to test the functions correctly. Now obvioulsy (3) is the best choice, but honestly, I am not motivated towards this at the moment. Which leaves (1) and (2), with (2) being the way I'm leaning. But the tests are getting really big, and pretty messy, and duplicating them and managing both versions looks like a nightmare (there are lots of TODOs, and I expect the tests to behave differently on different OS). So what is the recomendation that I do? In the simplest case, I can just copy the Ascii test to a new file and replace all 'A' with 'W', and just keep the tests seperated that way. Anyhow, any comments would be appreciated. Thanks, .Geoff

4 4

Re: Regression tests, UNICODE vs ASCII
by Lina Kemmel 14 Apr '02

14 Apr '02

P.S. By "2 code pages" I meant *ANSI* code pages, of course.. Lina Hi, At least 2 code pages contain a couple of BiDi control characters: * Left-to-Right Mark (LRM) and Right-to-Left Mark (RLM) present in both 1255 and 1256 code pages (0xFD and 0xFE); * Zero Width Non-Joiner (ZWNJ) and Zero Width Joiner (ZWJ) -- in cp1256 (0x9D and 0x9E). Lina Shachar Shemesh <wine-devel(a)sun.consumer.org.il> Sent by: wine-devel-admin(a)winehq.com 14/04/02 09:50 ص Please respond to Shachar Shemesh To: Francois Gouget <fgouget(a)free.fr> cc: Andriy Palamarchuk <apa3a(a)yahoo.com>, Geoffrey Hausheer <i8e7fkwmsl1(a)phracturedblue.com>, wine-devel(a)winehq.com Subject: Re: Regression tests, UNICODE vs ASCII One thing you may try are the explicit BiDi specifiers (Right to left, left to right etc.). These are Unicode characters designed to explicitly specify the direction of otherwise amigious characters. Ansii does not have, to the best of my knowledge, an equivalent encoded characters. Shachar Francois Gouget wrote: >On Mon, 8 Apr 2002, Andriy Palamarchuk wrote: > >>A couple comments: >>1) it is useful to check intermixed API calls, like >>A->W->A to be sure they do conversions correctly. >>2) while testing W functions use some Unicode symbols >>which do not have corresponding ASCII symbols. >> > > Could you give a couple examples of these Unicode symbols? I know >that I would be hard-pressed to make up a Unicode string with anything >significant. But if I had an example to base my code on, integrating it >into my own tests should be trivial. > >-- >Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > 1 + e ^ ( i * pi ) = 0 >

1 0

Re: Regression tests, UNICODE vs ASCII
by Lina Kemmel 14 Apr '02

14 Apr '02

Hi, At least 2 code pages contain a couple of BiDi control characters: * Left-to-Right Mark (LRM) and Right-to-Left Mark (RLM) present in both 1255 and 1256 code pages (0xFD and 0xFE); * Zero Width Non-Joiner (ZWNJ) and Zero Width Joiner (ZWJ) -- in cp1256 (0x9D and 0x9E). Lina Shachar Shemesh <wine-devel(a)sun.consumer.org.il> Sent by: wine-devel-admin(a)winehq.com 14/04/02 09:50 ص Please respond to Shachar Shemesh To: Francois Gouget <fgouget(a)free.fr> cc: Andriy Palamarchuk <apa3a(a)yahoo.com>, Geoffrey Hausheer <i8e7fkwmsl1(a)phracturedblue.com>, wine-devel(a)winehq.com Subject: Re: Regression tests, UNICODE vs ASCII One thing you may try are the explicit BiDi specifiers (Right to left, left to right etc.). These are Unicode characters designed to explicitly specify the direction of otherwise amigious characters. Ansii does not have, to the best of my knowledge, an equivalent encoded characters. Shachar Francois Gouget wrote: >On Mon, 8 Apr 2002, Andriy Palamarchuk wrote: > >>A couple comments: >>1) it is useful to check intermixed API calls, like >>A->W->A to be sure they do conversions correctly. >>2) while testing W functions use some Unicode symbols >>which do not have corresponding ASCII symbols. >> > > Could you give a couple examples of these Unicode symbols? I know >that I would be hard-pressed to make up a Unicode string with anything >significant. But if I had an example to base my code on, integrating it >into my own tests should be trivial. > >-- >Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > 1 + e ^ ( i * pi ) = 0 >

1 0

X11 fork available
by Ove Kaaven 13 Apr '02

13 Apr '02

Ever since the main Wine tree changed its license to the LGPL, a fork of the tree under the old license had seemed necessary, and been planned. This fork is now ready. If you're a Wine contributor that don't care all that much about forking, you do not need to leave the official LGPL-ed Wine tree to let the X11-licensed fork live. All you have to do is to agree to license your patches under the X11 license, so we are able to pick it up from wine-patches and apply it to the X11 tree whenever possible. This will make your contributions more widely used, so we encourage as many as possible to do so. And if it's out of the question for you, then we encourage you to tell us that, so that we know that we can never apply your patches. The fork's name was decided after a lot of brainstorming by Eric and me, when we found a name which we both liked... ReWind. It can stand for "Re-engineering Windows", or something like "Rewind to the old Windows days". The fork is currently hosted on SourceForge. The homepage is thus http://rewind.sourceforge.net/ for now. It's not a very fancy page, but all the necessary CVS and mailing list information is there. Go there if you're interested in contributing actively to ReWind. Patches known to come from X11-friendly contributors are already applied to the CVS, but many more patches are waiting for the authors to declare a stance. The CVS repository that ReWind is based on is the WineHQ repository, cleansed of all post-LGPL commits (except the Before-LGPL tag), so all the CVS history of the pre-LGPL Wine is present in the ReWind CVS repository. This ensures that no history is lost in the event that the X11 fork prevails over the LGPL fork. Your help to achieve this is welcome. Followups to this post should preferably go to wine-license. Thanks for your attention.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel