wine-devel

wine-devel@winehq.org

2 participants
84471 discussions

Bug in ICO_ExtractIconExW
by mehmet yasar 17 Feb '02

17 Feb '02

Hi, I have a systematic crash when browsing a folder which has a *.gz file inside (for example using GetOpenFileName). In my system, the icon of "gz" files are associated to an external "ico" file, I see it with --debugmsg +shell : warn:shell:ParseFieldA ("C:\\PROGRAM FILES\\POWERARCHIVER\\ICONS\\GZIP.ICO",0x00000002,0x405c574c,5) semi-stub. The crash happens in line 325 of exticon.c: RetPtr[i-nIconIndex] = LookupIconIdFromDirectoryEx( pCIDir, TRUE, cxDesired, cyDesired, 0); With Winedbg we see : i = 65386, nIconIndex = -151, nIcons = 1 and IconDirCount = 1 It seems to be linked to this bogus test (line 314): else if( nIconIndex < iconDirCount ) where nIconIndex(INT)=-151 and iconDirCount(UINT16)=1. I Hope this will help finding the correct solution. (Odd fact : when activating +relay there is no more crash ...) Mehmet YASAR --------------- Backtrace with Wine20020122 --------------- First chance exception: page fault on write access to 0x406059a8 in 32-bit code (0x4082ba06). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:008f GS:0000 EIP:4082ba06 ESP:405c5888 EBP:405c5910 EFLAGS:00210287( R- 00 I S - -P1C) EAX:00000000 EBX:408c9b78 ECX:405c59a8 EDX:00010000 ESI:ffffff6a EDI:ffffff69 Stack dump: 0x405c5888 (NTDLL.DLL.memcpy+0x31fb08): 405c58d4 00000104 ffffff69 405c597c 0x405c5898 (NTDLL.DLL.memcpy+0x31fb18): 00000020 40a29a58 40388974 403aafce 0x405c58a8 (NTDLL.DLL.memcpy+0x31fb28): 405c59cc 40a17878 00000000 4006c7ea 0x405c58b8 (NTDLL.DLL.memcpy+0x31fb38): 400aa1ba 400ae78d 401018d7 405c5a2e 0x405c58c8 (NTDLL.DLL.memcpy+0x31fb48): 40133efe 403b6cbe 405c5a24 00000000 0x405c58d8 (NTDLL.DLL.memcpy+0x31fb58): 00000000 403c40b8 408bffb5 00000f6e 0x405c58e8 (NTDLL.DLL.memcpy+0x31fb68): 0011: sel=008f base=4011a4e0 limit=00000fff 32-bit rw- Backtrace: =>0 0x4082ba06 (ICO_ExtractIconExW+0x386(lpszExeFileName=0x403c4558, RetPtr=0x405c59a8, nIconIndex=0xffffff69, nIcons=0x1, cxDesired=0x20, cyDesired=0x20) [exticon.c:325] in libuser32.so) (ebp=405c5910) 1 0x4082c1c5 (PrivateExtractIconsW+0xf5(lpwstrFile=0x403c4558, nIndex=0xffffff69, sizeX=0x20, sizeY=0x20, phicon=0x405c59a8, w=0x0, nIcons=0x1, y=0x0) [exticon.c:555] in libuser32.so) (ebp=405c5948) 2 0x4082c251 (PrivateExtractIconsA+0x71(lpstrFile=0x405c5a20, nIndex=0xffffff69, sizeX=0x20, sizeY=0x20, phicon=0x405c59a8, w=0x0, nIcons=0x1, y=0x0) [exticon.c:578] in libuser32.so) (ebp=405c597c) 3 0x4065ed8d (SIC_LoadIcon+0x3d(sSourceFile=0x405c5a20, dwSourceIndex=0xffffff69) [iconcache.c:115] in libshell32.so) (ebp=405c59b8) 4 0x4065eeb9 (SIC_GetIconIndex+0xb9(sSourceFile=0x405c5a20, dwSourceIndex=0xffffff69) [iconcache.c:154] in libshell32.so) (ebp=405c5a00) 5 0x4065f32c (PidlToSicIndex+0xcc(sh=0x403c48f4, pidl=0x403b6cb0, bBigIcon=0x0, uFlags=0x0, pIndex=0x405c5b58) [iconcache.c:311] in libshell32.so) (ebp=405c5b3c) 6 0x4065f3d2 (SHMapPIDLToSystemImageListIndex+0x72(sh=0x403c48f4, pidl=0x403b6cb0, pIndex=0x0) [iconcache.c:346] in libshell32.so) (ebp=405c5b68) 7 0x40677e61 (ShellView_OnNotify+0x3b1(This=0x403bd0c4, CtlID=0xffffff4f, lpnmh=0x405c626c) [shlview.c:1178] in libshell32.so) (ebp=405c600c) 8 0x4067850e (ShellView_WndProc+0x18e(hWnd=0x30034, uMessage=0x4e, wParam=0xffffff4f, lParam=0x405c626c) [shlview.c:1405] in libshell32.so) (ebp=405c602c) 9 0x408947a3 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=405c6050) 10 0x4089483d (WINPROC_CallWndProc+0x8d(proc=0x40678380, hwnd=0x30034, msg=0x4e, wParam=0xffffff4f, lParam=0x405c626c) [winproc.c:167] in libuser32.so) (ebp=405c6080) 11 0x4089a46a (WINPROC_CallProc32WTo32A+0x8a(func=0x40678380, hwnd=0x30034, msg=0x4e, wParam=0xffffff4f, lParam=0x405c626c) [winproc.c:2439] in libuser32.so) (ebp=405c60a8) 12 0x4089aa32 (CallWindowProcW+0xb2(func=0x40b606d2, hwnd=0x30034, msg=0x4e, wParam=0xffffff4f, lParam=0x405c626c) [winproc.c:2646] in libuser32.so) (ebp=405c60dc) 13 0x40830727 (call_window_proc+0xd7(hwnd=0x30034, msg=0x4e, wparam=0xffffff4f, lparam=0x405c626c, unicode=0x1) [message.c:1351] in libuser32.so) (ebp=405c6138) 14 0x40831301 (SendMessageTimeoutW+0xe1(hwnd=0x30034, msg=0x4e, wparam=0xffffff4f, lparam=0x405c626c, flags=0x0, timeout=0xffffffff, res_ptr=0x405c61bc) [message.c:1721] in libuser32.so) (ebp=405c6198) 15 0x40831587 (SendMessageW+0x37(hwnd=0x30034, msg=0x4e, wparam=0xffffff4f, lparam=0x405c626c) [message.c:1801] in libuser32.so) (ebp=405c61cc) 16 0x4096b033 (dispinfo_notifyT+0x1d3(self=0x30035, code=0xffffff4f, pdi=0x405c626c, isW=0x1) [listview.c:330] in libcomctl32.so) (ebp=405c6234) 17 0x40971f9e (LISTVIEW_GetItemT+0x34e(hwnd=0x30035, lpLVItem=0x405c630c, internal=0x1, isW=0x1) [listview.c:5040] in libcomctl32.so) (ebp=405c62b8) 18 0x4096ed6d (LISTVIEW_DrawItem+0xed(hwnd=0x30035, hdc=0x860, nItem=0x1, rcItem=0x0, FullSelect=0x0, SuggestedFocus=0x405c67b8) [listview.c:354] in libcomctl32.so) (ebp=405c6748) 19 0x4096ffd5 (LISTVIEW_RefreshList+0x175(hwnd=0x30035, hdc=0x860, cdmode=0x0) [listview.c:3552] in libcomctl32.so) (ebp=405c67e4) 20 0x4097036f (LISTVIEW_Refresh+0xbf(hwnd=0x30035, hdc=0x860) [listview.c:3677] in libcomctl32.so) (ebp=405c6824) 21 0x4097633e (LISTVIEW_Paint+0x5e(hwnd=0x30035, hdc=0x0) [listview.c:8170] in libcomctl32.so) (ebp=405c6880) 22 0x40977a70 (LISTVIEW_WindowProc+0xdc0(hwnd=0x30035, uMsg=0xf, wParam=0x0, lParam=0x0) [listview.c:8922] in libcomctl32.so) (ebp=405c689c) 23 0x408947a3 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=405c68c0) 24 0x4089483d (WINPROC_CallWndProc+0x8d(proc=0x40976cb0, hwnd=0x30035, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:167] in libuser32.so) (ebp=405c68f0) 25 0x4089aa4e (CallWindowProcW+0xce(func=0x40b604b4, hwnd=0x30035, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2650] in libuser32.so) (ebp=405c6924) 26 0x4087c494 (DispatchMessageW+0x134(msg=0x405c69a0) [message.c:1126] in libuser32.so) (ebp=405c6968) 27 0x40870b26 (IsDialogMessageW+0xb6(hwndDlg=0x20023, msg=0x405c69a0) [dialog.c:1533] in libuser32.so) (ebp=405c698c) 28 0x4086fe10 (DIALOG_DoDialogBox+0xa0(hwnd=0x20023, owner=0x10021) [dialog.c:1040] in libuser32.so) (ebp=405c69cc) 29 0x408701af (DialogBoxIndirectParamA+0x2f(hInstance=0x405e5000, template=0x40622a60, owner=0x10021, dlgProc=0x405ee730, param=0x403b7798) [dialog.c:1163] in libuser32.so) (ebp=405c69e0) 30 0x405ed76c (GetFileName95+0x10c(fodInfos=0x403b7798) [filedlg95.c:249] in libcomdlg32.so) (ebp=405c6a08) 31 0x405edc02 (GetFileDialog95W+0x352(ofn=0x1008c40, iDlgType=0x2) [filedlg95.c:467] in libcomdlg32.so) (ebp=405c6a6c) 32 0x405ed580 (GetOpenFileNameW+0x40(ofn=0x1008c40) [filedlg.c:1606] in libcomdlg32.so) (ebp=405c6a88) 33 0x01001dc1 (notepad.exe..text+0xdc1 in C:\winnt\notepad.exe) (ebp=405c6ce8) 34 0x010028bd (notepad.exe..text+0x18bd in C:\winnt\notepad.exe) (ebp=405c6d08) 35 0x408947a3 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=405c6d2c) 36 0x4089483d (WINPROC_CallWndProc+0x8d(proc=0x100248f, hwnd=0x10021, msg=0x111, wParam=0xa, lParam=0x0) [winproc.c:167] in libuser32.so) (ebp=405c6d5c) 37 0x4089aa4e (CallWindowProcW+0xce(func=0x40b60640, hwnd=0x10021, msg=0x111, wParam=0xa, lParam=0x0) [winproc.c:2650] in libuser32.so) (ebp=405c6d90) 38 0x4087c494 (DispatchMessageW+0x134(msg=0x405c6dec) [message.c:1126] in libuser32.so) (ebp=405c6dd4) 39 0x01002a64 (notepad.exe..text+0x1a64 in C:\winnt\notepad.exe) (ebp=405c6e08) 40 0x01006576 (notepad.exe.EntryPoint+0x156 in C:\winnt\notepad.exe) (ebp=405c6ea4) 41 0x400d3b18 (start_process+0x1f8 [process.c:397] in libntdll.so) (ebp=405c6f38) 42 0x400d7307 (call_on_thread_stack+0x27(func=0x400d3920) [sysdeps.c:91] in libntdll.so) (ebp=405c6ff4) 43 0x400d74c0 (SYSDEPS_CallOnStack+0x14 in libntdll.so) (ebp=00000000) 0x4082ba06 (ICO_ExtractIconExW+0x386 [exticon.c:325] in libuser32.so): movl %eax,0x0(%ecx,%edx,4) 320 for( i = nIconIndex; i < nIconIndex + nIcons; i++ )

2 1

Newbie Trying To Get Ghost Recon To Install
by Joel Miller 17 Feb '02

17 Feb '02

Hello, I'm new to using WINE (and to these lists), so I apologize if this has been asked and answered already: Has anyone been able to get Ghost Recon to at least install? The autorun program came up just fine, but when I click the button to install, it promptly quits. I tried running the setup.exe program directly, and it gets as far as trying to setup and install shield wizard, and then gives me an error mesage box stating that it cannot load a certain dll. I do not recall the name of the dll, and I do not have immediate access to the GR installer -- I borrowed my friend's discs and manuals to see if it would work under WINE. When I found out last week that it wouldn't install, I returned them =-(. I might be able to borrow them again, though. I am running the latest WINE on this box: * SuSE Linux 7.1 * 1Ghz Athlon * SiS Mainboard * 256MB RAM * GeForce 2-MX (not using nVidia's drivers, just the ones that come with SuSE) * 60GB HD I am trying to set up an MS-Free game machine, so using an existing WhineDoze install just isn't gonna happen. =-) Any help offered will be greatly appreciated. Joel Miller

2 1

Re: ldconfig : ..... .so is not a symbolic link
by lawson_whitney＠juno.com 17 Feb '02

17 Feb '02

On Fri, 15 Feb 2002, Sylvain Petreolle wrote: > > ldconfig -v produces : > /usr/local/lib: libopengl32.so -> libopengl32.so libglu32.so -> libglu32.so libmsvcrt20.so -> libmsvcrt20.so libsane.so.1 -> libsane.so.1.0.7 ldconfig: /usr/local/lib/libwine_unicode.so is not a symbolic link libwine_unicode.so -> libwine_unicode.so.1.0 ldconfig: /usr/local/lib/libwine_tsx11.so is not a symbolic link libwine_tsx11.so -> libwine_tsx11.so.1.0 .... Not only that, but make uninstall make install is broken. I thought that would fix it, but I had to install the wine binary by hand, and the result is exactly the same. Where there were symbolic links before are now copies. Besides wasting file space, though, I don't see it does any harm. You get this mail by the latest Wine, ldconfig warnings and all. Lawson First shoot the arrow. Then draw the bulls-eye. - J. A. Soucy

4 5

RE: BSD, Gav, LGPL, Jeremy, and business
by Roger Fujii 17 Feb '02

17 Feb '02

> > if you have to give out an unlimited, royalty free license to your > > work, I think it's not unfair to say that you have given up your > > copyright protection. As the copyright holder, it's true that you > > can relicense it to suit other licenses, but it's not clear to me > > that you can clearly make a copyright infringment case if there is > > an LGPLed copy in the public. > Well if somebody uses my work in a way either not permitted by LGPL > or explicitly permited by me through some other license I can't see > why I can't sue. But the point I'm trying to make is that I can be in violation of your RELICENSE. I can make a claim that YOUR work is covered by the *GPL, so that your RElicense to me doesn't apply. If this holds, then my original statement that you gave up your copyright protection holds. -r

1 0

RE: BSD, Gav, LGPL, Jeremy, and business
by Patrik Stridvall 16 Feb '02

16 Feb '02

> > The *GPL extends the circumstances where I can take somebodies work. > > but isn't this notion rather frightening? Frightning? Have you been effected with Brett fear mongering? :-) I don't consider it frightning. Copyleft is a trade where someone was allowed distribute my work and did and as companation I can take his related work. Of course this is not always good as I have been arguing in countless mail, but that is another thing. Sometimes this is good idea sometimes it is not. > > > nor does it force you to give up your copyright (effectively). > > > > Neither does the LGPL you can still license the code to others > > under any license. You just have to give it back under the > > LGPL as well. > > if you have to give out an unlimited, royalty free license to your > work, I think it's not unfair to say that you have given up your > copyright protection. As the copyright holder, it's true that you > can relicense it to suit other licenses, but it's not clear to me > that you can clearly make a copyright infringment case if there is > an LGPLed copy in the public. Well if somebody uses my work in a way either not permitted by LGPL or explicitly permited by me through some other license I can't see why I can't sue. At least not unless you claim that Open Source == Public Domain, but that is something else entirely.

1 0

RE: BSD, Gav, LGPL, Jeremy, and business
by Roger Fujii 16 Feb '02

16 Feb '02

> > while this is one *small* aspect of copyleft, the *GPL extends > > well beyond that. "fair use" does not allow you to redistribute > > work, > > Yes, it does, that it what fair use is: > The right to distribute somebody elses work or > part of work without a license under some > circumstances. you're right. I was just thinking in terms of backups and work as a whole. Good reading: http://www-sul.stanford.edu/cpyright.html > The *GPL extends the circumstances where I can take somebodies work. but isn't this notion rather frightening? > > nor does it force you to give up your copyright (effectively). > > Neither does the LGPL you can still license the code to others > under any license. You just have to give it back under the > LGPL as well. if you have to give out an unlimited, royalty free license to your work, I think it's not unfair to say that you have given up your copyright protection. As the copyright holder, it's true that you can relicense it to suit other licenses, but it's not clear to me that you can clearly make a copyright infringment case if there is an LGPLed copy in the public. -r

1 0

Re: Clarification on my call for license change
by Roger Fujii 16 Feb '02

16 Feb '02

Aric Stewart <aric(a)codeweavers.com> wrote: > The simple of it is.. you, Patrik, would not buy a Wine distribution > form us. Why would you? You are a developer, and a wine developer on top of that. What seems to be the most commercially successful mode on top of opensource is to have an opensource base and have a value-add component - but I have yet to see a successful mode that has no propriatary component. > It is these sorts of people and companies that we want to target. And > financially Patrik's money for his license or even the money form all > the wine developers would be nearly insignificant compared to a 100+ > seat site license. uh, how can you sell a N-seat site license with something that is covered by *GPL (since this would be a violation of the license)? If your model is to sell by seat, I would like you see the reasoning between the difference of a 10 seat license and a 100 seat license with the *GPL. > As a developer who has worked on far too many proprietary Wine trees and > seen all the fights the Jeremy has gone through. I want to be assured that > i can give my code back to the wine community. As I said before, if a copyleft is all that is needed, choose a copyleft that makes SENSE. LGPL may be convienient, but I have seen no rational argument in having the *GPL's brand of copyleft (other than it's widely used). I think the mozilla project would be a good place to look... -r

2 1

RE: BSD, Gav, LGPL, Jeremy, and business
by Patrik Stridvall 16 Feb '02

16 Feb '02

> Patrik Stridvall wrote: > > > No. If anything, it seems to be using licencing rules > > > to negate copyrights. It really wants to make a copyright > > > into "a right to copy it". Even taking what you say, if you > > > extend what is "fair" use, you obviously must be making it > > > less fair somewhere else.... > > > > As I said, very simplified. > > > > What I meant is that the mechanism that forces release of > > the extension of the LGPL (read: copyleft) is similar to the > > case where fair use is extended so I take legally take > > the work instead. > > while this is one *small* aspect of copyleft, the *GPL extends > well beyond that. "fair use" does not allow you to redistribute > work, Yes, it does, that it what fair use is: The right to distribute somebody elses work or part of work without a license under some circumstances. The *GPL extends the circumstances where I can take somebodies work. > nor does it force you to give up your copyright (effectively). Neither does the LGPL you can still license the code to others under any license. You just have to give it back under the LGPL as well. > > The copyleft mechanism forces "push" of the source code > > which is better in the case of software. > > > I by this wanted to illustrate that copyleft is not something > > inherantly "evil" as Brett Glass are apparently crusading against. > > I'll let Brett speak for himself (not like I can stop him :) ), but > I didn't see an argument that 'copyleft' was bad. It was the *GPL is > bad. Just as rms think proprietary programs are evil, Brett > and others > think that the loss of copyright protections are just as bad or worse. Perhaps. But as you said, let Brett speak for himself. > I'm not quite as concerned as Brett, as I think the viral > nature of the > *GPL will eventually be thrown out in US court. Yes, I think that too.

1 0

RE: BSD, Gav, LGPL, Jeremy, and business
by Patrik Stridvall 16 Feb '02

16 Feb '02

> At 02:38 AM 2/16/2002, Patrik Stridvall wrote: > > >I'm sorry if I sound a little angry but it seems that some > >of people have found me guilty by association with you > > Patrik, don't you see? We're both guilty of the same sin: > saying that everything does not revolve around the Earth. > While we have different views of how things DO work, > there's exceedingly strong evidence for what we say. Perhaps. But I think you seem to focus on worst case scenarios, many of them are IMHO unlikely to happend, which impacts negatively on your credebillity. > But because it's contrary to some people's "religious" > beliefs they would rather excommunicate us, suppress > what we have to say, or burn us at the stake than listen. I don't think it is quite that easy. I don't think most of them have an "religious" belief in the LGPL. I think they simple see it as a way to both eat the cake and have it while trivialize the price they have to pay in the order to acceive this. Note, however, that sometimes, but only sometimes, this price is actually worth paying, see below. > >What you are doing IMHO is pure fear mongering, > > No, it's not. I am making predictions based on what > has happened to other businesses in the recent past, > as well as sound economic principles. I'm not advocating > or attempting to induce fear. I do not believe that you try to induce fear, but by focusing on unlikely to happend scenarios you cause fear regarless. > But if the outcome does not > look rosy, it's because WINE really would head down a > very destructive path if it were (L)GPLed. Wine will survive regardless. However I very much fear that it might impact negatively on the willingless of companies to invest in the Wine market and thus reducing the speed which Wine develops with. Note that when Wine fully works (close to 100% of all Windows applications run) it will not matter what license we have, there will be no money in anything except support anyway and the LGPL will not hurt that. It is the way there that worries me. Note that we can always choose LGPL later, but after we have choosen it we can't go back. > >I firmly believe that the GPL and the LGPL has > >a place in the world. > > Their place, and purpose, has been stated by Stallman. > (Not in the licenses themselves, which are designed > to be deceptive, but in Stallman's words in his more > candid moments.) It is to turn publicly available > software into a weapon in his lifelong, personal > vendetta. Again, he has stated this explicitly > himself, and it is also well documented by third parties > such as Levy. Please, now you are fear mongering again. I care not whether I support Stallman or not. I care ONLY about what is good for Wine. > WINE should rise above this agenda and not become an > agent of it. What agenda? The GPL/LGPL works in ways that are almost the dual to fair use. Very simplified: It uses copyright to extend fair use. Fair use have an obvious place in the world. However trying to extend fair use to legalize (or rather rationalize) for example Napster like sharing of music clearly takes things too far. GPL/LGPL have an obvious place in the world. However it has close to the same price as fair use, it discourages investment in new works using classical business models and new business models need to be found. This is obvously not so easy, neither in music business nor in the software business. Possible, yes. Easy, no. Don't try to stretch my analogy to far. The point is this and only this: The GPL/LGPL have a place in the world for almost the same reasons that fair use have a place in the world. However if trying to extend fair use too far is not good, neither is trying it extend GPL/LGPL too far. While fair use is nessesary an author can't live of it. The same with GPL/LGPL.

3 2

RE: Clarification on my call for license change
by Patrik Stridvall 16 Feb '02

16 Feb '02

> Patrik Stridvall wrote: > > > The point is: > > - The 100+ seat company gains. (They get support). > > - Red Hat gains. (They get money). > > - I gain. (I get money). > > - But CodeWeavers, that did a lot of work on Wine, > > doesn't gain anything and they are becaused of the LGPL > > been forced to release all of their work. > > > > Sure they might gain back a few bug fixes if I had to > > do in order to fix a few small flaws, but then Red Hat > > probably would have let me release it anyway. > > A few bug fixes? If it is important enough that such a big > customer pays > Red Hat for developing something then I guess that it is not > only a few > bug fixes we are talking about here. Well, if they just want a support contract the applications they use probably works fine in usual case thanks to the works of others that I have download for free thanks to the LGPL and made a RPM for them. But OK there will probably more that a few bugfixes but somehow I think that most of the time will be spent telling ignorant users the obvious, that is what support usually is. The support money will also pay for me making new RPMs for them from time to time get even more stuff for free thanks to LGPL. Beside a simple support contract are not likely to allow for advanced fixes without extra money being paid. The point is that CodeWeavers will not get any money at all. > And that is to the advantage of > CodeWeaver then because they gain also fucntionallity they might have > needed to develop themself. Yea sure, but don't have too much hopes that it will be that much. Support means support not development. Beside Red Hat would probably have let me release the fixes back even if they didn't have too since the license was still BSD. If their applications works under Wine, there is no reason for me to implement any new functions.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel