wine-devel

wine-devel@winehq.org

3 participants
84399 discussions

Re: SNOOP: How to find out if an DLL entry is a DATA reference?
by Alexandre Julliard 14 Aug '01

14 Aug '01

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > However I like to ask if there are other methods of distinguishing DATA and > function references? Could the PE loader perhaps know? Or can we perhaps > protect our snoop entries from being read as data and catch those exceptions? > Any other idea? I don't think there's any way to make snoop 100% reliable, the PE file simply doesn't contain enough information. This is the reason we have to build special tables in the builtin dlls for relay debugging. -- Alexandre Julliard julliard(a)winehq.com

1 0

Advice please. adding a MODULE_LoadLibraryExA argument
by Bill Medland 14 Aug '01

14 Aug '01

I'd appreciate advice on this. I am looking at adding the handling of LoadLibraryExA (..LOAD_WITH_ALTERED_SEARCH_PATH) (which we use) and I am wondering about how to carry around the library directory during the recursion on MODULE_LoadLibraryExA. The easiest way is to put it in a static variable (ok, some allocated memory pointed to by a static variable) and depend upon the existing critical sections (which I don't understand particularly) to ensure it is only used by the currently loading tree of DLLS (i.e. set it up after the RtlAcquirePebLock in MODULE_LoadLibraryExA). However I dislike using static variables as a matter of principle. The way I would prefer would be to add an argument to all the functions in the recursion and use that to carry the name around. MODULE_LoadLibraryExA PE_LoadLibraryExA ELF_LoadLibraryExA PE_CreateModule fixup_imports Any objections? Bill

1 0

Solaris X86 mmap...
by Robert Lunnon 14 Aug '01

14 Aug '01

On Jan 10 2001 Ulrich Weigand submitted a patch to library/port.c to attempt to fix the linux mmap behaviour dependency for solaris systems. After that point I can't find any reference to this patch, it certainly hasn't made it into the CVS yet ? Does anyone know the outcome of this work, or am I the only Solaris X86 user out there :-)

1 0

SNOOP: How to find out if an DLL entry is a DATA reference?
by Uwe Bonnes 14 Aug '01

14 Aug '01

Hallo, e.g. with the MFC libraries the snoop option crashes quite often, while without snoop the programm proceeds some more. Digging deeper for the crash in msdev.exe, I saw that a library has exported DATA entries mixed into the codesegment. Our snoop loader only checks for DATA entries in the PE DATA section and so happyly overwrites data. It seems that most exported DATA entries have a decorated name ending in @A or @B and by handling entries with that ending as DATA, the crash with msdev.exe happens at the same place with or without snoop. Appended patch does this hacky search for DATA entries. However I like to ask if there are other methods of distinguishing DATA and function references? Could the PE loader perhaps know? Or can we perhaps protect our snoop entries from being read as data and catch those exceptions? Any other idea? Bye Changelog: relay32/snoop.c: SNOOP_GetProcAddress Don't snoop on names ending in "@A" and "@B", they seem to be DATA entries. Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Free Software: If you contribute nothing, expect nothing -- Index: wine/relay32/snoop.c =================================================================== RCS file: /home/wine/wine/relay32/snoop.c,v retrieving revision 1.45 diff -u -r1.45 snoop.c --- wine/relay32/snoop.c 24 Jul 2001 21:45:24 -0000 1.45 +++ wine/relay32/snoop.c 13 Aug 2001 19:51:42 -0000 @@ -158,7 +158,7 @@ SNOOP_GetProcAddress(HMODULE hmod,LPCSTR name,DWORD ordinal,FARPROC origfun) { SNOOP_DLL *dll = firstdll; SNOOP_FUN *fun; - int j; + int j,len; IMAGE_SECTION_HEADER *pe_seg = PE_SECTIONS(hmod); if (!TRACE_ON(snoop)) return origfun; @@ -182,7 +182,14 @@ !(pe_seg[j].Characteristics & IMAGE_SCN_CNT_CODE) ) return origfun; - + /* some heuristic to filter out DATA objects + decorated names end like "@A" and "@B" and some more */ + len=strlen(name); + if ((name [len-2] == '@') && ((name[len-1] == 'A') || (name[len-1] == 'B'))) + { + return origfun; + } + while (dll) { if (hmod == dll->hmod) break;

2 1

IShellLinkA_fnSetIconLocation problem with Kid Pix 3?
by Dan Kegel 13 Aug '01

13 Aug '01

Kid Pix 3 doesn't install with Wine from cvs (with either August 6th's or today's cvs). The problem appears to be related to shortcut or icon creation, as the installer bombs with alert "Cannot create shortcuts." right after checking for the existence of "Picker.ico". Here is what seems to be the interesting 250-line section of the log, starting with the fnSetIconLocation and ending with the "Cannot create shortcuts". There is an iffy looking line near the bottom I've marked with !!!!!!!!!!!!!. I'd be grateful for any suggestions. Thanks, Dan trace:shell:IShellLinkA_fnSetIconLocation (0x418884bc)->(path=C:\Program Files\Broderbund\Kid Pix Deluxe 3\Picker.ico iicon=0) trace:shell:IShellLinkA_fnQueryInterface (0x418884bc)->( IID: {0000010b-0000-0000-c000-000000000046}) trace:shell:IPersistFile_fnAddRef (0x418884bc)->(count=1) trace:shell:IShellLinkA_fnAddRef (0x418884bc)->(count=1) trace:shell:IShellLinkA_fnQueryInterface -- Interface: (0x405d53fc)->(0x418884c8) 08077c28:Call kernel32.MultiByteToWideChar(00000000,00000000,405d51dc "C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk",ffffffff,405d4dc0,00000104) ret=100394e7 08077c28:Ret kernel32.MultiByteToWideChar() retval=00000034 ret=100394e7 trace:shell:IPersistFile_fnSave (0x418884bc)->(L"C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk") 08077c28:Call advapi32.RegOpenKeyExA(80000002,40879140 "Software\\Wine\\Wine\\Config\\Wine",00000000,000f003f,405d490c) ret=408563c4 08077c28:Call ntdll.RtlInitAnsiString(405d47dc,40879140 "Software\\Wine\\Wine\\Config\\Wine") ret=407afaa4 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407afaa4 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d47dc,00000000) ret=407afaad 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407afaad 08077c28:Call ntdll.NtOpenKey(405d490c,000f003f,405d47e4) ret=407afac0 trace:reg:NtOpenKey (0x80000002,L"Software\\Wine\\Wine\\Config\\Wine",f003f,0x405d490c) trace:reg:NtOpenKey <- 0x0034 08077c28:Ret ntdll.NtOpenKey() retval=00000000 ret=407afac0 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407afac6 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407afac6 08077c28:Ret advapi32.RegOpenKeyExA() retval=00000000 ret=408563c4 08077c28:Call advapi32.RegQueryValueExA(00000034,4087915f "ShellLinker",00000000,405d4904,405d4c90,405d4908) ret=408563fb trace:reg:RegQueryValueExA (0x34,"ShellLinker",(nil),0x405d4904,0x405d4c90,0x405d4908=260) 08077c28:Call ntdll.RtlInitAnsiString(405d46f4,4087915f "ShellLinker") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d46f4,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d46fc,00000100,405d46f0) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"ShellLinker",2,0x405d46fc,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=00000000 ret=407b0cc4 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4708 L"wineshelllink",0000000e,00000000,00000000,00000000,00000000) ret=407b0ddc 08077c28:Ret kernel32.WideCharToMultiByte() retval=0000000e ret=407b0ddc 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4708 L"wineshelllink",0000000e,405d4c90,0000000e,00000000,00000000) ret=407b0e1b 08077c28:Ret kernel32.WideCharToMultiByte() retval=0000000e ret=407b0e1b 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000000 ret=408563fb 08077c28:Call advapi32.RegCloseKey(00000034) ret=40856411 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=40856411 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4dc0 L"C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk",ffffffff,405d4c90,00000104,00000000,00000000) ret=40856482 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000034 ret=40856482 08077c28:Call kernel32.GetFullPathNameA(405d4c90 "C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk",00000104,405d4b80,00000000) ret=408564b0 trace:string:lstrcpynA (0x405d43dc, "C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk", 1024) trace:string:lstrcpynA (0x405d4b80, "C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk", 260) 08077c28:Ret kernel32.GetFullPathNameA() retval=00000033 ret=408564b0 trace:shell:SHGetSpecialFolderPathA 0x0000,0x405d4c90,csidl=7,0x0000 08077c28:Call advapi32.RegCreateKeyExA(80000001,4087bb20 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders",00000000,00000000,00000000,000f003f,00000000,405d4568,405d456c) ret=4085d37e 08077c28:Call ntdll.RtlInitAnsiString(405d443c,4087bb20 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders") ret=407af91e 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407af91e 08077c28:Call ntdll.RtlInitAnsiString(405d4434,00000000) ret=407af92d 08077c28:Ret ntdll.RtlInitAnsiString() retval=400bf8ac ret=407af92d 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d443c,00000000) ret=407af936 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af936 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(405d442c,405d4434,00000001) ret=407af94a 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af94a 08077c28:Call ntdll.NtCreateKey(405d4568,000f003f,405d4444,00000000,405d442c,00000000,405d456c) ret=407af968 trace:reg:NtCreateKey (0x80000001,L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders",L"",0,f003f,0x405d4568) trace:reg:NtCreateKey <- 0x0034 08077c28:Ret ntdll.NtCreateKey() retval=00000000 ret=407af968 08077c28:Call ntdll.RtlFreeUnicodeString(405d442c) ret=407af970 08077c28:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=407af970 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407af976 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407af976 08077c28:Ret advapi32.RegCreateKeyExA() retval=00000000 ret=4085d37e 08077c28:Call advapi32.RegQueryValueExA(00000034,405d4790 "StartUp",00000000,405d4560,405d4c90,405d4564) ret=4085d3aa trace:reg:RegQueryValueExA (0x34,"StartUp",(nil),0x405d4560,0x405d4c90,0x405d4564=260) 08077c28:Call ntdll.RtlInitAnsiString(405d4374,405d4790 "StartUp") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d4374,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d437c,00000100,405d4370) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"StartUp",2,0x405d437c,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=c0000034 ret=407b0cc4 08077c28:Call ntdll.RtlNtStatusToDosError(c0000034) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000002 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000002 ret=4085d3aa 08077c28:Call advapi32.RegCloseKey(00000034) ret=4085d3bd 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=4085d3bd 08077c28:Call advapi32.RegCreateKeyExA(80000001,4087bac0 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",00000000,00000000,00000000,000f003f,00000000,405d4568,405d456c) ret=4085d3e8 08077c28:Call ntdll.RtlInitAnsiString(405d443c,4087bac0 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders") ret=407af91e 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407af91e 08077c28:Call ntdll.RtlInitAnsiString(405d4434,00000000) ret=407af92d 08077c28:Ret ntdll.RtlInitAnsiString() retval=400bf8ac ret=407af92d 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d443c,00000000) ret=407af936 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af936 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(405d442c,405d4434,00000001) ret=407af94a 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af94a 08077c28:Call ntdll.NtCreateKey(405d4568,000f003f,405d4444,00000000,405d442c,00000000,405d456c) ret=407af968 trace:reg:NtCreateKey (0x80000001,L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",L"",0,f003f,0x405d4568) trace:reg:NtCreateKey <- 0x0034 08077c28:Ret ntdll.NtCreateKey() retval=00000000 ret=407af968 08077c28:Call ntdll.RtlFreeUnicodeString(405d442c) ret=407af970 08077c28:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=407af970 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407af976 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407af976 08077c28:Ret advapi32.RegCreateKeyExA() retval=00000000 ret=4085d3e8 08077c28:Call advapi32.RegQueryValueExA(00000034,405d4790 "StartUp",00000000,405d4560,405d4c90,405d4564) ret=4085d408 trace:reg:RegQueryValueExA (0x34,"StartUp",(nil),0x405d4560,0x405d4c90,0x405d4564=260) 08077c28:Call ntdll.RtlInitAnsiString(405d4374,405d4790 "StartUp") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d4374,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d437c,00000100,405d4370) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"StartUp",2,0x405d437c,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=00000000 ret=407b0cc4 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4388 L"C:\\WINDOWS\\Start Menu\\Programs\\Startup",00000027,00000000,00000000,00000000,00000000) ret=407b0ddc 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000027 ret=407b0ddc 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4388 L"C:\\WINDOWS\\Start Menu\\Programs\\Startup",00000027,405d4c90,00000027,00000000,00000000) ret=407b0e1b 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000027 ret=407b0e1b 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000000 ret=4085d408 08077c28:Call advapi32.RegCloseKey(00000034) ret=4085d579 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=4085d579 08077c28:Call shlwapi.PathFileExistsA(405d4c90 "C:\\WINDOWS\\Start Menu\\Programs\\Startup") ret=4085d7d6 trace:shell:PathFileExistsA C:\WINDOWS\Start Menu\Programs\Startup 08077c28:Call kernel32.GetFileAttributesA(405d4c90 "C:\\WINDOWS\\Start Menu\\Programs\\Startup") ret=408fd447 trace:string:lstrcpynA (0x405d3bfc, "/home/dank/.wine/fake_windows", 1024) 08077c28:Ret kernel32.GetFileAttributesA() retval=00000010 ret=408fd447 08077c28:Ret shlwapi.PathFileExistsA() retval=00000001 ret=4085d7d6 trace:shell:SHGetSpecialFolderPathA 0x0000,0x405d4c90,csidl=16,0x0000 08077c28:Call advapi32.RegCreateKeyExA(80000001,4087bb20 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders",00000000,00000000,00000000,000f003f,00000000,405d4568,405d456c) ret=4085d37e 08077c28:Call ntdll.RtlInitAnsiString(405d443c,4087bb20 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders") ret=407af91e 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407af91e 08077c28:Call ntdll.RtlInitAnsiString(405d4434,00000000) ret=407af92d 08077c28:Ret ntdll.RtlInitAnsiString() retval=400bf8ac ret=407af92d 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d443c,00000000) ret=407af936 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af936 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(405d442c,405d4434,00000001) ret=407af94a 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af94a 08077c28:Call ntdll.NtCreateKey(405d4568,000f003f,405d4444,00000000,405d442c,00000000,405d456c) ret=407af968 trace:reg:NtCreateKey (0x80000001,L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders",L"",0,f003f,0x405d4568) trace:reg:NtCreateKey <- 0x0034 08077c28:Ret ntdll.NtCreateKey() retval=00000000 ret=407af968 08077c28:Call ntdll.RtlFreeUnicodeString(405d442c) ret=407af970 08077c28:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=407af970 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407af976 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407af976 08077c28:Ret advapi32.RegCreateKeyExA() retval=00000000 ret=4085d37e 08077c28:Call advapi32.RegQueryValueExA(00000034,405d4790 "Desktop",00000000,405d4560,405d4c90,405d4564) ret=4085d3aa trace:reg:RegQueryValueExA (0x34,"Desktop",(nil),0x405d4560,0x405d4c90,0x405d4564=260) 08077c28:Call ntdll.RtlInitAnsiString(405d4374,405d4790 "Desktop") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d4374,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d437c,00000100,405d4370) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"Desktop",2,0x405d437c,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=c0000034 ret=407b0cc4 08077c28:Call ntdll.RtlNtStatusToDosError(c0000034) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000002 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000002 ret=4085d3aa 08077c28:Call advapi32.RegCloseKey(00000034) ret=4085d3bd 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=4085d3bd 08077c28:Call advapi32.RegCreateKeyExA(80000001,4087bac0 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",00000000,00000000,00000000,000f003f,00000000,405d4568,405d456c) ret=4085d3e8 08077c28:Call ntdll.RtlInitAnsiString(405d443c,4087bac0 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders") ret=407af91e 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407af91e 08077c28:Call ntdll.RtlInitAnsiString(405d4434,00000000) ret=407af92d 08077c28:Ret ntdll.RtlInitAnsiString() retval=400bf8ac ret=407af92d 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d443c,00000000) ret=407af936 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af936 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(405d442c,405d4434,00000001) ret=407af94a 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af94a 08077c28:Call ntdll.NtCreateKey(405d4568,000f003f,405d4444,00000000,405d442c,00000000,405d456c) ret=407af968 trace:reg:NtCreateKey (0x80000001,L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",L"",0,f003f,0x405d4568) trace:reg:NtCreateKey <- 0x0034 08077c28:Ret ntdll.NtCreateKey() retval=00000000 ret=407af968 08077c28:Call ntdll.RtlFreeUnicodeString(405d442c) ret=407af970 08077c28:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=407af970 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407af976 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407af976 08077c28:Ret advapi32.RegCreateKeyExA() retval=00000000 ret=4085d3e8 08077c28:Call advapi32.RegQueryValueExA(00000034,405d4790 "Desktop",00000000,405d4560,405d4c90,405d4564) ret=4085d408 trace:reg:RegQueryValueExA (0x34,"Desktop",(nil),0x405d4560,0x405d4c90,0x405d4564=260) 08077c28:Call ntdll.RtlInitAnsiString(405d4374,405d4790 "Desktop") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d4374,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d437c,00000100,405d4370) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"Desktop",2,0x405d437c,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=00000000 ret=407b0cc4 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4388 L"C:\\WINDOWS\\Desktop",00000013,00000000,00000000,00000000,00000000) ret=407b0ddc 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000013 ret=407b0ddc 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4388 L"C:\\WINDOWS\\Desktop",00000013,405d4c90,00000013,00000000,00000000) ret=407b0e1b 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000013 ret=407b0e1b 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000000 ret=4085d408 08077c28:Call advapi32.RegCloseKey(00000034) ret=4085d579 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=4085d579 08077c28:Call shlwapi.PathFileExistsA(405d4c90 "C:\\WINDOWS\\Desktop") ret=4085d7d6 trace:shell:PathFileExistsA C:\WINDOWS\Desktop 08077c28:Call kernel32.GetFileAttributesA(405d4c90 "C:\\WINDOWS\\Desktop") ret=408fd447 trace:string:lstrcpynA (0x405d3bfc, "/home/dank/.wine/fake_windows", 1024) 08077c28:Ret kernel32.GetFileAttributesA() retval=00000010 ret=408fd447 08077c28:Ret shlwapi.PathFileExistsA() retval=00000001 ret=4085d7d6 08077c28:Call kernel32.wine_get_unix_file_name(4187b708 "C:\\Program Files\\Broderbund\\Kid Pix Deluxe 3\\KPRUN.EXE",405d4a70,00000104) ret=4085669d trace:string:lstrcpynA (0x405d4004, "/home/dank/.wine/fake_windows", 1024) trace:string:lstrcpynA (0x405d4a70, "/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3/KPRUN.EXE", 260) 08077c28:Ret kernel32.wine_get_unix_file_name() retval=00000001 ret=4085669d 08077c28:Call kernel32.wine_get_unix_file_name(41888530 "C:\\Program Files\\Broderbund\\Kid Pix Deluxe 3",405d4960,00000104) ret=4085671c trace:string:lstrcpynA (0x405d4004, "/home/dank/.wine/fake_windows", 1024) trace:string:lstrcpynA (0x405d4960, "/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3", 260) 08077c28:Ret kernel32.wine_get_unix_file_name() retval=00000001 ret=4085671c 08077c28:Call kernel32.LoadLibraryExA(4188856c "C:\\Program Files\\Broderbund\\Kid Pix Deluxe 3\\Picker.ico",00000000,00000002) ret=40855d46 trace:string:lstrcpynA (0x405d3e70, "/home/dank/.wine/fake_windows", 1024) warn:dosfs:DOSFS_FindUnixName 'Picker.ico' not found in '/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3' trace:string:lstrcpynA (0x405d3e2c, "/home/dank/.wine/fake_windows", 1024) warn:dosfs:DOSFS_FindUnixName 'Picker.ico' not found in '/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3' trace:string:lstrcpynA (0x418886ec, "C:\\WINDOWS\\SYSTEM", 260) !!!!!!!!!!!!!!!!!!!! why is it trying to load C:\WINDOWS\SYSTEM?! !!!!!!!!!!!!!!!!! warn:module:MODULE_LoadLibraryExA Failed to load module 'C:\WINDOWS\SYSTEM'; error=0x00000002, 08077c28:Ret kernel32.LoadLibraryExA() retval=00000000 ret=40855d46 trace:shell:ExtractFromEXEDLL LoadLibraryExA (C:\Program Files\Broderbund\Kid Pix Deluxe 3\Picker.ico) failed, error 2 trace:shell:IPersistFile_fnSave linker app='wineshelllink' link='Shortcut to Kid Pix Deluxe 3' mode=desktop path='/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3/KPRUN.EXE' args=' Main' icon='/tmp/fileUlFDEJ' workdir='/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3' descr='' fixme:pthread_kill_other_threads_np trace:shell:IPersistFile_fnRelease (0x418884bc)->(count=2) trace:shell:IShellLinkA_fnRelease (0x418884bc)->(count=2) trace:shell:IShellLinkA_fnRelease (0x418884bc)->(count=1) trace:shell:IShellLinkA_fnRelease -- destroying IShellLink(0x418884bc) 08077c28:Call ole32.CoUninitialize() ret=10039541 08077c28:Call kernel32.FreeLibrary(40845000) ret=408b00fc 08077c28:Ret kernel32.FreeLibrary() retval=00000001 ret=408b00fc 08077c28:Ret ole32.CoUninitialize() retval=00000000 ret=10039541 08077c28:Call window proc 0x416979 (hwnd=000001c0,msg=WM_USER+000c,wp=00000000,lp=00000000) 08077c28:Ret window proc 0x416979 (hwnd=000001c0,msg=WM_USER+000c,wp=00000000,lp=00000000) retval=00000000 08077c28:Call kernel32.lstrlenA(0048636c "") ret=00417ef4 08077c28:Ret kernel32.lstrlenA() retval=00000000 ret=00417ef4 08077c28:Call kernel32.lstrcpyA(4185a0e7,0048636c "") ret=0041801e 08077c28:Ret kernel32.lstrcpyA() retval=4185a0e7 ret=0041801e 08077c28:Call kernel32.lstrcpyA(405d6144,40491e32 "MESSAGE_CANNOT_CREATE_ICONS") ret=0041832a 08077c28:Ret kernel32.lstrcpyA() retval=405d6144 ret=0041832a 08077c28:Call kernel32.lstrlenA(4043bcec "Cannot create shortcuts.") ret=0045714a -- "I have seen the future, and it licks itself clean." -- Bucky Katt

1 0

Re: Question about network stuff
by Bobby Bingham 12 Aug '01

12 Aug '01

I'm not sure of the answer to your problem (could you be a little more specific than "it basically told me it couldn't access the network.) This isn't the right list for this question. This list is for patches that have been submitted to WINE. You might try the wine-users mailing list, or, if you're really daring, the wine-devel list if no one on wine-users knows Bobby Bingham Microsoft Windows: Made for the internet The Internet: Made for UNIX On Sunday 12 August 2001 02:02 am, you wrote: > Hi there > > (am I even on the right list??) > > I've been trying to get some Internet playable games to work with Wine, > namely everquest. > > I started out by making the mistake of running wine from my home dir (like > wine /win/d/everquest/everquest.exe) and having it download the whole game > from the 'net to my home dir.. I stopped that in a hurry :-) > > When I moved to /win/d/everquest, and tried to do wine ./everquest, it > basically told me it couldn't access the network. > > Why? How do I fix this? > > Thanks a ton, > > Tim

1 0

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?
by Alexandre Julliard 11 Aug '01

11 Aug '01

Patrik Stridvall <ps(a)leissner.se> writes: > So to the details of the marshalling API (the unmarshalling API can wait). > 1. Where should we put them? Suggestion: include/wine/messsage.h No, it should be private to the dlls that really need it. We shouldn't add a global Wine-specific interface, we already have too many of that. And please don't go around converting all SendMessage calls to some marshalling API; this should be reserved to the cases where there is really a need. This is why I suggested to add the inline function in the C file directly: if there is a file where there are a lot of WM_COMMANDs with ugly casts, you can add an inline function there. But if there is only one or two, or calls that don't need ugly typecasts (most of them don't), then you definitely don't want to use the inline, just do a normal SendMessage. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?
by Patrik Stridvall 11 Aug '01

11 Aug '01

> Patrik Stridvall <ps(a)leissner.se> writes: > > > We can just do it like: > > #ifdef __GNUC__ > > extern inline void FORWARD_WM_COMMAND(HWND hwnd, int id, > HWND hwndCtl, UINT > > codeNotify, WNDPROC fn) > > { > > fn(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), (LPARAM) hwnd); > > } > > #else > > #define FORWARD_WM_COMMAND(hwnd, id, hwndCtl, codeNotify, fn) \ > > (void)(fn)((hwnd), WM_COMMAND, > > MAKEWPARAM((UINT)(id),(UINT)(codeNotify)), (LPARAM)(HWND)(hwndCtl)) > > #endif > > > > if you wish. And if you are worried about preprocessor abusing > > Winelib application we could do #if defined(__GNUC__) && > defined(__WINE__) > > instead or use some kind of macro wrap around protection of the > > kind that I proposed that you didn't like. > > If you want to wrap WM_COMMAND, do something like: > > inline void send_wm_command(HWND hwnd, int id, HWND hwndCtl, > UINT codeNotify) > { > SendMessageW(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), > (LPARAM)hwndCtl); > } > > This is a normal function, doing a normal SendMessage call, and it's > perfectly all right with me. And if you want to do a PostMessage then > write a separate post_wm_command() function. Of course this is not a > standard Windows API so you cannot put it in the standard header > files; but you can have it in some dll private headers, or even > directly in the C files that need it. Ironically that was approximately my original idea. But I didn't think you would accept it so I didn't bother investigating further. Then I realized that the windowsx.h macros did what I wanted so choosed that solution instead. But sure we have a marshalling/unmarshalling API of our own, if that is what you want. Unless of course you prefer the hack below for PostMessage (not likely :-). So to the details of the marshalling API (the unmarshalling API can wait). 1. Where should we put them? Suggestion: include/wine/messsage.h 2. What should we call them? Suggestion: {POST,SEND}_WM_COMMAND etc. We really should capitalize the message name because of people doing "grep WM_COMMAND". And not capitalizing the POST/SEND would look silly if the suffix is capitalized. Sure they look like macros but then they could easily be made to be as an alterative implemention like #define SEND_WM_COMMAND(hwnd, id, hwndCtl, codeNotify) \ FORWARD_WM_COMMAND(hwnd, id, hwndCtl, codeNotify, SendMessage) 3. Do you want the macro wrapper (against the FORWARD API) above for the non GNU C case? 4. Should have have {POST,SEND}_WM_COMMAND{A,W} for calling {Post,Send}Message{A,W} or should we always the W variant like in your example above. > > To sum it up: > > 1. The FORWARD_* API and the HANDLE_* API really are normal > functions not > > macros (preprocessor abuses). The fact Micrsoft > implemented them as macros > > because of lack of compiler support for inline functions > or because of > > incompetence is irrelevant, we can do it right in a 100% > compatible way. > > No we can't; SendMessage and PostMessage don't have the same > prototype, so the preprocessor abuse is necessary to avoid > warnings. It seems you are right. PostMessage returns BOOL. Anyway there are not so many PostMessage calls that can be converted. $ find . -name \*.c | xargs grep PostMessage | grep WM_ | wc -l 35 The type compatible ones on the other hand are $ find . -name \*.c | xargs egrep 'Def.*Proc' | grep WM_ | wc -l 33 $ find . -name \*.c | xargs grep SendMessage | grep WM_ | wc -l 420 The Def.*Proc ones doesn't seem of closer examination to require marshalling of parameters so let skip them. Total 420 compared to 35. So we either decide not to use the the FORWARD_ API for such cases or we do: BOOL bResult = (BOOL) FORWARD_WM_COMMAND(/* ... */, (WNDPROC) PostMessageW); The use above is type correct regardless of whether FORWARD_WM_COMMAND is a macro or a inline function. A little ugly yes, but then it isn't nessary to convert the few PostMessage that exists to the FORWARD_* API at all.

1 0

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?
by Alexandre Julliard 11 Aug '01

11 Aug '01

Patrik Stridvall <ps(a)leissner.se> writes: > We can just do it like: > #ifdef __GNUC__ > extern inline void FORWARD_WM_COMMAND(HWND hwnd, int id, HWND hwndCtl, UINT > codeNotify, WNDPROC fn) > { > fn(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), (LPARAM) hwnd); > } > #else > #define FORWARD_WM_COMMAND(hwnd, id, hwndCtl, codeNotify, fn) \ > (void)(fn)((hwnd), WM_COMMAND, > MAKEWPARAM((UINT)(id),(UINT)(codeNotify)), (LPARAM)(HWND)(hwndCtl)) > #endif > > if you wish. And if you are worried about preprocessor abusing > Winelib application we could do #if defined(__GNUC__) && defined(__WINE__) > instead or use some kind of macro wrap around protection of the > kind that I proposed that you didn't like. If you want to wrap WM_COMMAND, do something like: inline void send_wm_command(HWND hwnd, int id, HWND hwndCtl, UINT codeNotify) { SendMessageW(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), (LPARAM)hwndCtl); } This is a normal function, doing a normal SendMessage call, and it's perfectly all right with me. And if you want to do a PostMessage then write a separate post_wm_command() function. Of course this is not a standard Windows API so you cannot put it in the standard header files; but you can have it in some dll private headers, or even directly in the C files that need it. > To sum it up: > 1. The FORWARD_* API and the HANDLE_* API really are normal functions not > macros (preprocessor abuses). The fact Micrsoft implemented them as macros > because of lack of compiler support for inline functions or because of > incompetence is irrelevant, we can do it right in a 100% compatible way. No we can't; SendMessage and PostMessage don't have the same prototype, so the preprocessor abuse is necessary to avoid warnings. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?
by Patrik Stridvall 11 Aug '01

11 Aug '01

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Microsoft introduced the windowsx.h macros for a reason and > > while without inline functions the current implementation > > of the FORWARD_* macros was the best they could do, it > > was at least better than nothing since it at least handled > > the parameter marshalling even if it wasn't 100% type safe. > > I wouldn't rely on Microsoft choices to judge an API design ;-) Point taken. :-) However not everything Microsoft does is bad, eventhough I admit that being sceptical is a good start. > > Another things to think about: > > What is the difference between calling {Set,Get}WindowText > > functions and calling the FORWARD_WM_{GET,SET}TEXT macros? > > It's a matter of taste. Calling a normal function is perfectly all > right; But they are normal functions. It is just not that apparent that they really are. Whether this is by design or by accident I leave unsaid. :-) Anyway, see below. > but I find that using a macro (or worse an inline function > masquerading as a macro) and having to pass it the name of the > function you want to call is ugly and offensive. If you want to call > SendMessage, then call SendMessage, don't hide it inside a macro. It is not hidden in the macro. Which function to call is provided as the last parameter of the macro. > Just because you can do all kinds of abuses of the preprocessor in C > doesn't mean you should. Well actually, the so called abuses of the preprocesor was for 100% compabillity with Winelib applications, if they abuse the fact that FORWARD_* might not always be macros (like doing undef on them). It is possible do it cleaner that the crude example I provide as well. Anyway, with the exception of preprocessor abusing application, which Wine easily can be made not to be. We can just do it like: #ifdef __GNUC__ extern inline void FORWARD_WM_COMMAND(HWND hwnd, int id, HWND hwndCtl, UINT codeNotify, WNDPROC fn) { fn(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), (LPARAM) hwnd); } #else #define FORWARD_WM_COMMAND(hwnd, id, hwndCtl, codeNotify, fn) \ (void)(fn)((hwnd), WM_COMMAND, MAKEWPARAM((UINT)(id),(UINT)(codeNotify)), (LPARAM)(HWND)(hwndCtl)) #endif if you wish. And if you are worried about preprocessor abusing Winelib application we could do #if defined(__GNUC__) && defined(__WINE__) instead or use some kind of macro wrap around protection of the kind that I proposed that you didn't like. Note that the above inline function "abuses" that fact that C autocasts between functions and pointer to functions, but then it standard well documented and often used "abuse", so calling it an abuse isn't really fair (not that you did since my example contained an unnessary &)). To sum it up: 1. The FORWARD_* API and the HANDLE_* API really are normal functions not macros (preprocessor abuses). The fact Micrsoft implemented them as macros because of lack of compiler support for inline functions or because of incompetence is irrelevant, we can do it right in a 100% compatible way. 2. The FORWARD_* API provides marshalling of parameters and the HANDLE_* API provides unmarshalling of parameters. 3. The FORWARD_* API provides type safe sending of parameters and the HANDLE_* API provides type safe recieving of parameters. Note that the fact that marshalling and unmarshalling of parameters are hidden makes that code much more readable and yes, I say it again, the FORWARD_* API and HANDLE_* API really are normal functions, there is no hidden traps for the unwary user. Just a nice wrapper for type safe marshalling and unmarshalling of parameters. PS. We could easily rewrite the HANDLE_* API as inline functions as well, I don't think it gives us anything though. They are good as they are AFAICS. But if you don't like macros, sure I can rewrite them as inline functions well. It just a lot of work to no gain AFAICS. It wouldn't hurt either though.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel