wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: Add support for NOMINMAX
by Alexandre Julliard 11 May '01

11 May '01

Francois Gouget <fgouget(a)free.fr> writes: > Why? It doesn't make a big difference but after all, if min/max are > defined in their own header, why not take advantage of it to avoid > duplication? (I hate duplicating code :-) Because that's not how Windows does it. And I think it's a good thing to avoid unnecessary dependencies between the Windows headers and the MSVC ones. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Add support for NOMINMAX
by Francois Gouget 11 May '01

11 May '01

I noticed that you didn't apply this part of the minmax patch: --- cut here --- Index: include/windef.h =================================================================== RCS file: /home/cvs/wine/wine/include/windef.h,v retrieving revision 1.57 diff -u -r1.57 windef.h --- include/windef.h 2001/05/07 20:14:00 1.57 +++ include/windef.h 2001/05/11 01:17:37 @@ -14,6 +14,9 @@ #define WINVER 0x0500 #include "winnt.h" +#ifndef NOMINMAX +#include "minmax.h" +#endif #ifdef __cplusplus @@ -140,15 +143,6 @@ #define ADD_LOWORD(dw,val) ((dw) = ((dw) & 0xffff0000) | LOWORD((DWORD)(dw)+(val))) #endif -/* min and max macros */ -#ifndef NOMINMAX -#ifndef max -#define max(a,b) (((a) > (b)) ? (a) : (b)) -#endif -#ifndef min -#define min(a,b) (((a) < (b)) ? (a) : (b)) -#endif -#endif /* NOMINMAX */ #ifndef _MAX_PATH /* FIXME: These are supposed to be in stdlib.h only */ --- cut here --- Why? It doesn't make a big difference but after all, if min/max are defined in their own header, why not take advantage of it to avoid duplication? (I hate duplicating code :-) -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ La terre est une bêta...

1 0

[PATCH] Small SetParent fix
by gerard patel 10 May '01

10 May '01

Calling SetParent of a child window does not create a X counterpart in current Cvs if parent = 0. Fixes one at least of the 2 crashes I had pointed to with the User patch of 24 april. ChangeLog: * dlls/x11drv/window.c creates (again) a X counterpart for children windows reparented to 0

1 0

Re: GDB remote debugging
by Alexandre Julliard 10 May '01

10 May '01

Ove Kaaven <ovehk(a)ping.uio.no> writes: > I assume Alexandre isn't going to like some of the stuff in here, but I > suppose it's up to him whether to take it or leave it... How did you guess I wouldn't like it? ;-) Actually I think it's a neat hack, but it doesn't belong in the server at all. You should be able to do the same thing as a client-side process using the Win32 debugging API. It could be either a stand-alone Winelib app, or a special mode inside winedbg so that you can reuse some of the code in there. -- Alexandre Julliard julliard(a)winehq.com

3 2

Small Fixes
by kenon＠go2.pl 10 May '01

10 May '01

Hi, I had some problems with application Super Memo 8.0 . It is an old 16-bit app ( hard for debugging :-) ) written in Borland Delphi (I guess). I wrote a patch and posted to wine-patches two months ago ,but that patch was rejected :-( . Now I have much simpler and I think correct patch solving the problem. --- windows/painting.c_or Wed Mar 28 16:39:17 2001 +++ windows/painting.c Sat May 5 14:19:43 2001 @@ -1710,7 +1710,7 @@ { /* send palette change notification */ HWND hWnd = WindowFromDC( hDC ); - if (hWnd) SendMessageA( HWND_BROADCAST, WM_PALETTECHANGED, hWnd, 0L); + if (hWnd) PostMessageA( HWND_BROADCAST, WM_PALETTECHANGED, hWnd, 0L); } return realized; } There is another bug. When I press <ENTER> the app runs in other way under wine than it runs under Windoze. My workaround ( only workaround ) is --- controls/edit.c_or Thu May 10 03:24:06 2001 +++ controls/edit.c Thu May 10 03:24:10 2001 @@ -849,7 +849,7 @@ case WM_GETDLGCODE: DPRINTF_EDIT_MSG32("WM_GETDLGCODE"); - result = DLGC_HASSETSEL | DLGC_WANTCHARS | DLGC_WANTARROWS; + result = DLGC_HASSETSEL | DLGC_WANTCHARS | DLGC_WANTARROWS |DLGC_WANTMESSAGE; if (lParam && (((LPMSG)lParam)->message == WM_KEYDOWN)) { --

1 0

Is the DECIMAL variant type too long ?
by gerard patel 10 May '01

10 May '01

After the following patch : ChangeSet ID: 989259340138108821120113 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard@wine2. 01/05/07 14:15:40 Modified files: include : oleauto.h wtypes.h include/wine : obj_base.h obj_oleaut.h Log message: Francois Gouget <fgouget(a)codeweavers.com> Added support for the DECIMAL type. Names are no longer suffixed with 32! Removed it. Borland Builder 4 crashes while starting :-/ Tracing the crash shows that it hangs immediately after the *first* variant Api access : Call oleaut32.VariantCopyInd(405869b0,40586974) ret=405b2e6b tid=08065a10 trace:ole:VariantCopyInd (0x405869b0, 0x40586974) trace:ole:VariantCopy (0x405869b0, 0x40586974) trace:ole:VariantClear (0x405869b0) Ret oleaut32.VariantCopyInd() retval=00000000 ret=405b2e6b tid=08065a10 Call oleaut32.VariantChangeTypeEx(40586968,405869b0,00000400,00000000,00000003) ret=405b301c tid=08065a10 trace:ole:VariantInit (0x4058685c),stub trace:ole:VariantChangeTypeEx (0x40586968, 0x405869b0 (11), 1024, 0, 3),stub trace:ole:VariantClear (0x40586968) trace:ole:VarI4FromBool ( -1, 0x40586970 ), stub trace:ole:VariantClear (0x4058685c) Ret oleaut32.VariantChangeTypeEx() retval=00000000 ret=405b301c tid=08065a10 err:seh:EXC_DefaultHandling Exception frame is not in stack limits => unable to dispatch exception. I have changed the trace slightly, the 11 listed for the VariantChangeTypeEx shows that the original type is a boolean. The call is trying to change a boolean (11) into an integer (3). The changes in include/wtypes.h are the important ones. Replacing the new DECIMAL type by typedef struct tagDEC { BYTE aa[2]; } DECIMAL; get rid of the crash. If I make the byte array 16 bytes long, same crash as the current Wine behaviour. If I make it 10 bytes long, access violation. If I make it 8 bytes long, it works too. Could the DECIMAL type be a pointer to the real data ?? Gerard

2 1

Stupid winedbg question
by Francois Gouget 10 May '01

10 May '01

This is probably a stupid question but I did not find the answer in the doc (Wine Developper's Guide). How do I copy-paste something from winedbg? A backtrace for instance. Or how do I copy/paste anything to/from any console application for that matter. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

4 6

Stupid autoconf question
by Ian Pilcher 09 May '01

09 May '01

Here is my first cut at adding a check for the FreeType libraries and header files to the Wine configuration scripts. It's basically a copy of Marcus' CUPS stuff. Since this is the first time I've done anything with autoconf, I figured I'd post it here for review: diff -urN ../wine-20010502cvs/configure.in ./configure.in --- ../wine-20010502cvs/configure.in Wed May 2 12:57:30 2001 +++ ./configure.in Thu May 3 01:44:48 2001 @@ -378,6 +378,19 @@ ) AC_SUBST(CUPSLIBS) +FREETYPELIBS="" +dnl **** Check for FreeType 2 **** +wine_cv_warn_ftsystem_h=no +AC_CHECK_LIB(freetype,FT_Init_FreeType, + AC_CHECK_HEADER(freetype2/freetype/ftsystem.h, + AC_DEFINE(HAVE_FREETYPE) + FREETYPELIBS="-lfreetype" + FREETYPEINCL="-I/usr/include/freetype2", + wine_cv_warn_ftsystem_h=yes) +) +AC_SUBST(FREETYPELIBS) +AC_SUBST(FREETYPEINCL) + dnl **** Check for IPX (currently Linux only) **** AC_CACHE_CHECK("for GNU style IPX support", ac_cv_c_ipx_gnu, AC_TRY_COMPILE( @@ -1316,6 +1329,15 @@ echo "*** Note: You have cups runtime libraries, but no development" echo "*** libraries. Install the cups-devel package or whichever package" echo "*** contains cups.h to enable CUPS support in WINE." +fi + +if test "$wine_cv_warn_ftsystem_h" = "yes" +then + echo + echo "*** Note: Your system appears to have the FreeType 2 runtime libraries" + echo "*** installed, but the corresponding header files are not installed in" + echo "*** /usr/include/freetype2/freetype. Install the freetype-devel package" + echo "*** to enable TrueType font support in Wine." fi echo diff -urN ../wine-20010502cvs/dlls/wineps/Makefile.in ./dlls/wineps/Makefile.in --- ../wine-20010502cvs/dlls/wineps/Makefile.in Sun Apr 29 13:21:22 2001 +++ ./dlls/wineps/Makefile.in Thu May 3 01:45:13 2001 @@ -6,7 +6,8 @@ SOVERSION = 1.0 ALTNAMES = wineps16 IMPORTS = user32 gdi32 winspool.drv kernel32 ntdll -EXTRALIBS = @CUPSLIBS@ +EXTRALIBS = @CUPSLIBS@ @FREETYPELIBS@ +EXTRAINCL = @FREETYPEINCL@ C_SRCS = \ afm.c \ diff -urN ../wine-20010502cvs/include/acconfig.h ./include/acconfig.h --- ../wine-20010502cvs/include/acconfig.h Sun Apr 29 13:21:22 2001 +++ ./include/acconfig.h Thu May 3 01:45:04 2001 @@ -122,3 +122,6 @@ /* Define if we have CUPS */ #undef HAVE_CUPS + +/* Define if FreeType 2 is installed */ +#undef HAVE_FREETYPE It seems to work on my system (Red Hat 7.1), although for some reason it can't even detect the FreeType library when the freetype-devel package is removed (no great loss). At this point I have a couple of questions: * Does anyone see anything wrong with this? * I've omitted the resulting changes to wine/configure and wine/include/config.h.in from the patch above. Is this form more convenient for final submission, or should I include the changes to those files? (If the latter is the case, I'll probably go ahead and submit the autoconf changes before I get any code written, so that wine/configure doesn't get hugely out of sync.) Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

3 3

Re: doors IPC
by Alexandre Julliard 09 May '01

09 May '01

Marcus Meissner <marcus(a)jet.franken.de> writes: > Since critical sections are thought to be 'fast' and 'short time' locking > primitives, and Win32 threads should not sleep in a critical section, > we can just give up our timeslice and wait for the other thread that > has the lock to continue. Well, there are tons of places where we will sleep inside a critical section, so it could potentially burn a lot of CPU. That doesn't necessarily make it slower, but it would probably impact other applications more. As usual, the only way to tell is to do benchmarks. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Add missing newline to WARN messages
by Dmitry Timoshkov 09 May '01

09 May '01

"Francois Gouget" <fgouget(a)free.fr> wrote: > * I scanned the source for TRACE/WARN/ERR/FIXME statements without a > terminating newline. There are few cases where this is justified because > of following DPRINTFs. But most of the time there should be a \n > otherwise the trace will not be flushed to disk immediately and the logs > will look bad. You forgot to remove redundant ' around %s in the traces when output is made by debugstr_a or debugstr_w. Actually you removed some of them, but not all.

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel