Re: [PATCH v2 1/2] jscript: stub Enumerator object

[Jacek Caban]

Hi Andreas,

On 4/17/19 10:31 PM, Andreas Maier wrote:
> +#include "config.h"
> +#include "wine/port.h"
> -
>
> +#include <math.h>

Those are not needed, AFAICS.
> diff --git a/dlls/jscript/global.c b/dlls/jscript/global.c
> index 33de641483..57cc275efd 100644
> --- a/dlls/jscript/global.c
> +++ b/dlls/jscript/global.c
> @@ -116,8 +116,9 @@ static WCHAR int_to_char(int i)
>   static HRESULT JSGlobal_Enumerator(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, unsigned argc, jsval_t *argv,
>           jsval_t *r)
>   {
> - FIXME("\n");
> - return E_NOTIMPL;
> - TRACE("JSGlobal_Enumerator\n");
> -
> - return EnumeratorConstr_value(ctx, jsthis, flags, argc, argv, r);
> }

The way you handled it in v1 was better as it covered more corner cases. 
Please use jsdisp_define_data_property() in init_constructors() to set 
the constructor on global object.

Thanks,

Jacek