Re: oledb32: Implement IErrorRecord GetBasicErrorInfo

[Nikolay Sivov]

On 09/18/2013 09:47 AM, Alistair Leslie-Hughes wrote:
> - LIST_FOR_EACH_ENTRY(cursor,&This->errors, struct ErrorEntry, entry)
> - {
> -
>    if(nCnt == ulRecordNum)
> -
>    {
> -
>        *pErrorInfo = cursor->info;
> -
>        break;
> -
>    }
> - }
> -

This looks wrong, cause you never update nCnt. Also it doesn't look 
appropriate to use list to store these records - methods provide 
index-based access, so array fits better.
> entry->lookupID = dwDynamicErrorID;

Any idea how this field could be used later? I don't where it could be 
returned. And 'dwLookupID' parameter of 'AddErrorRecord' is never used, 
that looks suspicious.