Re: [PATCH 2/3] dwrite: Fix name section strings lookup

[Piotr Caban]

On 04/27/17 16:52, Nikolay Sivov wrote:
> On 27.04.2017 17:03, Piotr Caban wrote:
> > Signed-off-by: Piotr Caban
> >
> > dlls/dwrite/opentype.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> The problem with this patch is that we want to continue and add as many
> strings for different locales as possible. So the condition should set
> 'exists' to TRUE after first pair was added successfully and never touch
> it after.

Yes, sorry, this patch is incorrect. I think that it would be nice to 
not fail in hard way if any of the names were decoded. Also I'll check 
why name decoding fails here.

Thanks,
Piotr