Re: Fixing a regression test ...

[Duane Clark]

Paul Millar wrote:
> ChangeLog:
>   Replace references to D: (which might not exist) with C: (which we 
>   assume does)
> Index: dlls/kernel/tests/path.c
>
> RCS file: /home/wine/wine/dlls/kernel/tests/path.c,v
> retrieving revision 1.6
> diff -u -r1.6 path.c
> --- dlls/kernel/tests/path.c	5 Jul 2002 01:22:28 -0000	1.6
> +++ dlls/kernel/tests/path.c	12 Jul 2002 18:03:17 -0000
> @@ -673,9 +673,9 @@
>    ok(lstrcmpiA(SHORTFILE,strptr)==0,
>        "GetLongPathNameA returned part '%s' instead of '%s'",strptr,SHORTFILE);
>  /* Otherwise insert the missing leading slash */
> - sprintf(tmpstr,"D:%s\%s",SHORTDIR,SHORTFILE);
> - sprintf(tmpstr,"C:%s\%s",SHORTDIR,SHORTFILE);
> ok(GetFullPathNameA(tmpstr,MAX_PATH,tmpstr1,&strptr),"GetFullPathNameA failed");
> - sprintf(tmpstr,"D:\%s\%s",SHORTDIR,SHORTFILE);
> - sprintf(tmpstr,"C:\%s\%s",SHORTDIR,SHORTFILE);
> ok(lstrcmpiA(tmpstr,tmpstr1)==0,
>     "GetLongPathNameA returned '%s' instead of '%s'",tmpstr1,tmpstr);
> ok(lstrcmpiA(SHORTFILE,strptr)==0,

Actually, the purpose of that particular test was to check the behavior 
when the supplied path is on a different drive from the current drive. 
The current drive is presumably C:. But the test should have tested for 
the existence of drive D: before using it.