On 04/01/07, Christoph Bumiller e0425955@stud3.tuwien.ac.at wrote:
Yet the application (NFS:MW) page faults right at startup at the address of pDecl + 4 so something's amiss ... maybe this will get fixed automatically in one of the next patches or is due to some other weird thing that affects my sources (eh?) ... as long as no one else complains, lets leave it at this.
Nah, it's correct that the refcounts are broken at the moment. What Stefan probbly meant was that we might as well remove refcounting completely from that fucntion.
Just look again at the SetPixelShader function, this is how it looks in my current GIT (I didn't touch this one) :
3758 /* Handle recording of state blocks */ 3759 if (This->isRecordingState) { 3760 TRACE("Recording... not performing anything\n"); 3761 }
...
3769 3770 if (This->isRecordingState) { 3771 TRACE("Recording... not performing anything\n"); 3772 return WINED3D_OK; 3773 }
That doesn't look quite correct either, actually. One of those two if blocks should go, I'd say the first one.