Re: setupx.dll16: Handle the error case for VCPM_VSTATWRITE in vcpUICallbackProc16. (RESEND)

[Alexandre Julliard]

Gerald Pfeifer  writes:
> Just realized I did not see a response to this patch.  Based on
> feedback I received for a different patch, I looked at this patch
> again and believe it indeed is easier.
> - We only set, but never used cbres, so removing it loses nothing.
> - With this patch we now set the return value to VCPN_FAIL in this
> case.  However, this is not the only case in vcpUICallbackProc16;
> for example, in another case in this function we pass the return
> value of VCP_UI_CopyStart and that returns VCPN_FAIL all over the
> place.

That doesn't mean it's appropriate in this case. Unless there is
evidence that a zero return from VCPM_DISKPREPINFO is supposed to cause
an error, it's better not to change the current behavior.