Re: [PATCH 3/5] d3dcompiler: Check for missing return value semantics on the entry point.

[Zebediah Figura]

On 6/8/20 9:14 AM, Matteo Bruni wrote:
> On Sat, Jun 6, 2020 at 12:26 AM Zebediah Figura  wrote:
> > diff --git a/dlls/d3dcompiler_43/tests/hlsl_d3d9.c b/dlls/d3dcompiler_43/tests/hlsl_d3d9.c
> > index 059f39e4c3e..16d1e6dda05 100644
> > --- a/dlls/d3dcompiler_43/tests/hlsl_d3d9.c
> > +++ b/dlls/d3dcompiler_43/tests/hlsl_d3d9.c
> > @@ -1092,6 +1092,12 @@ static void test_fail(void)
> >           "{\n"
> >           "    return float4(0, 0, 0, 0);\n"
> >           "}",
> > -
> > -
> >    /* 15 */
> > -
> >    "float4 test()\n"
> > -
> >    "{\n"
> > -
> >    "    return float4(0, 0, 0, 0);\n"
> > -
> >    "}",
>
> Seems sensible, but, playing devil's advocate: does it fail if the
> function also has an out argument?

Yes. I can add that as a test.