On Thu, 16 Dec 2021 at 03:58, Conor McCarthy cmccarthy@codeweavers.com wrote:
December 16, 2021 4:17 AM, "Henri Verbeet" hverbeet@gmail.com wrote:
Does this actually make a difference in the generated code or observed performance for you? I suppose the patch isn't wrong as such, but it doesn't make a difference in the generated code for me. For me, gcc already eliminates the dead stores in both the 32-bit and the 64-bit builds.
I haven't checked but see no reason for it to differ in my build. But for code quality it makes sense to copy only the view as we don't need a copy of the descriptor. The optimised copy path will do it this way.
Right, fair enough.