On Sun, 1 Mar 2009, Austin English wrote:
There's already one skip() in the file for some unimplemented stuff, so basing these fixes on that (only skipping on ERROR_NOT_SUPPORTED). If that's not what we should be doing (and just let it fail instead), feel free to ignore. I asked on #winehackers but couldn't get a clear answer as to what skip() should be used for...
[...]
apiReturn = gGetIfEntry(&row);
- if (apiReturn == ERROR_NOT_SUPPORTED)
- {
skip("GetIfEntry is not supported\n");return;- }
If there are Windows versions that export these functions but don't implement them so that they systematically return ERROR_NOT_SUPPORTED, then a win_skip() is justified.
If there are legitimate reasons for Wine to return ERROR_NOT_SUPPORTED, besides 'we did not implement it yet for this platform', then a skip() is justified. So you would use a skip() if the graphics card does not support the 3D features you want to test for instance. Or to skip over the sound capture tests if the sound card has no capture capability.
However you should not add a skip() just to hide platform-specific test failures, or failures caused by unimplemented or partially implemented features.
In this case it's not totally clear cut but it does look like it would just hide unimplemented functionality. Note that Alexandre has been reworking this area quite a bit recently so maybe your original impetus for adding these is gone.