Damn ... I have attached the wrong diff.
Michael Stefaniuc wrote:
Ričardas Barkauskas wrote:
My first try for COM cleanup. Please donėt be too harsh :) If this is too large for one patch, please suggest how to split it.
This is not automatic clean up so I don't really expect it to be good on first try.
Heh! I have attached the raw diff generated by my coccinelle script. Looking at the interdiff between the two patches it looks like you caught everything. And the BADBADBAD() (*) from the generated patch are replaced with unsafe_impl_from_IDirectDrawSurface3(), very good.
If you want to do more COM cleanup I can give you the raw generated patches to save you some time.
bye michael
P.S.: (*) My script validates that impl_from_IFace() is called only from methods of that IFace. All other impl_from_IFace() calls are replaced with BADBADBAD().