Huw Davies wrote:
On Thu, Feb 07, 2019 at 09:41:32PM +0900, Byeongsik Jeon wrote:
Signed-off-by: Byeongsik Jeon bsjeon@hanmail.net
v3: Huw's comments are applied.
Thank you.
'Vertical' transform position issue: Vertical transform must be separated from the rotation transform and applied before the scale transform. This is an issue at lfWidth != 0. I'll post related patch later.
[v2 PATCH 4/7] is included in this patch.
Please don't merge patches that fix things with no-op patches.
I also didn't mean for you to change tategaki -> vertical throughout all the code, I just wanted it changed in the new code. We'll change the rest as we move things around.
I've sent in a new version of this patch with the fix pulled into a separate patch. Please update the rest of your patches and send the next few in.
Thank you.
I misinterpreted it. To avoid test bot failures, I will post updated patches after two patches have been committed.