Re: [PATCH 2/5] dwrite/tests: Some basic tests for fontface references

[Sebastian Lackner]

On 19.04.2016 19:10, Nikolay Sivov wrote:
> - hr = IDWriteFactory3_CreateFontFaceReference_(factory3, file, 0, DWRITE_FONT_SIMULATIONS_NONE, &ref);
> - ok(hr == S_OK, "got 0x%08x\n", hr);
> -
> - hr = IDWriteFontFaceReference_GetFontFile(ref, &file1);
> - ok(hr == S_OK, "got 0x%08x\n", hr);
> - ok(file != file1, "got %p, previous file %p\n", file1, file);

Also not really critical, but you might be leaking a reference to "ref" here.
> -
> - IDWriteFontFile_Release(file);
> - IDWriteFontFile_Release(file1);
>
> +}
>      IDWriteFactory3_Release(factory3);
>      DELETE_FONTFILE(path);
>  }