Re: [PATCH] netapi32/tests: Print NetWkstaTransportEnum error code on test failure

[Alex Henrie]

2017-12-19 23:08 GMT-07:00 Dmitry Timoshkov :
> Alex Henrie  wrote:
> > This will help us figure out why this test fails intermittently on
> > Windows 10.
>
> ...
> > - ok(apiReturn == RPC_X_NULL_REF_POINTER, "null pointer\n");
> > - ok(apiReturn == RPC_X_NULL_REF_POINTER,
> > -
> >   "NetWkstaTransportEnum returned %d\n", apiReturn);
>
> Since this is basically an NT status code it would help better when
> being printed in hex.

All of the other error messages in this function print apiReturn in
decimal, and almost all of the expected return values are pre-NT error
codes. It might still be helpful to print apiReturn in hex, but it's
not a clear improvement to me, and we'd want to change all the error
messages and not just this one.

-Alex