Hi,
Am 26.01.2016 um 03:54 schrieb Jianqiu Zhang:
Hi André Thanks for your review
Sorry for the delay, but I haven't noticed that I got assigned for reviewing. Could you please tell me the name of the application so I can do some testing? Further reviewing inlined below:
It's just a small demo program using pcap_dump , I will provide the program and source code in the attachment
Thx
Am 07.01.2016 um 09:49 schrieb Jianqiu Zhang:
+pcap_dumper_t* CDECL wine_pcap_dump_open(pcap_t *p, const char *fname) +{
- return pcap_dump_open(p, fname);
+}
This can't work, the wpcap function might be called with fname set to "C:\dump.pcap" and the native function will be confused by that.
Ah, I see, I didn't take this scheme in to consideration, I will try to use a helper function to convert the fname to UNIX fname Do you think it's a solution?
Wine needs to do that in other functions, have a look for wine_nt_to_unix_file_name
+void CDECL wine_pcap_dump(u_char *user, const struct pcap_pkthdr *h, const u_char *sp) +{
- return pcap_dump(user, h, sp);
+}
This should work, but where are pcap_dump_close and friends?
I just implement the stubs in that small program, and it doesn't contain pcap_dump_close and others Could I ask you how to find the friends of a certain function? I will implement them then
I mean: pcap_dump_ftell pcap_dump_file pcap_dump_flush
But I think those should go into a separate patch, but pcap_dump_close should go in this one...
+@ cdecl pcap_dump(str ptr str) wine_pcap_dump
Should be (ptr ptr ptr), there are no strings to be displayed
I will correct this in my next try :)
Jianqiu Zhang