Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

[Christian Costa]

Ben Klein a écrit :
> On 19 April 2010 19:43, Henri Verbeet  wrote:
> > On 19 April 2010 09:43, Christian Costa  wrote:
> > > +BOOL is_pow2(UINT num)
> > > +{
> > > - UINT i;
> > > -
> > > - if (!num) return FALSE;
> > > - for (i = 0; num >> 1; i++) num >>= 1;
> > > -
> > > - return (num << i) == num;
> > >
> > > +}
> >
> > This should at least be static. You can also just replace it with
> > "return !(num & (num - 1));". You don't care about 0, since you
> > already check that earlier in D3DXCheckTextureRequirements().
> > make_pow2() can probably be simplified as well.
>
> I guess it depends on how many times this function will be used
> whether or not 0 should be checked as well.

Not many. The check can be done. Especially if these functions are moved 
to util.c for reuse.
That said, I'm not sure if it makes any difference because 0 as input 
does not make sense either.