On Wed, Mar 23, 2016 at 5:00 AM, Huw Davies huw@codeweavers.com wrote:
On Tue, Mar 22, 2016 at 03:29:10PM -0700, Adam Buchbinder wrote:
On Tue, Mar 22, 2016 at 2:09 AM, Huw Davies huw@codeweavers.com wrote: More importantly, I get a test failure: richole.c:785: Test failed: Moved scrollbar is at 60, should be 0. (Range 0-160.)
Where? The TestBot completed okay in a variety of environments:
https://testbot.winehq.org/JobDetails.pl?Key=21524
and it works on my local workstation. The trace points to a helper function, which is being called with expected_nonzero = 0. There are four calls in test_ITextRange_ScrollIntoView which could be behind this; without logging information or a stack trace, I can't tell what's breaking.
It's failing for me on both OS/X and linux. Note, it's the implementation that's failing, the tests themselves are fine. Did you try running 'make test' on your local machine?
Huw.
Aargh! That's my bad; I *thought* I'd tested it. Implementing bStart = tomEnd is proving problematic, so I've reduced the scope, and I'll be sending a v2 patch to wine-patches@ shortly. Sorry about the noise!
Adam Buchbinder