Re: [PATCH 7/7] mfplat: Prevent use after free (Coverity)

[Fabian Maurer]

On Samstag, 23. April 2022 23:19:14 CEST Nikolay Sivov wrote:
> On 4/23/22 21:17, Fabian Maurer wrote:
> > Signed-off-by: Fabian Maurer
> >
> > dlls/mfplat/mediatype.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/dlls/mfplat/mediatype.c b/dlls/mfplat/mediatype.c
> > index 71d55e2d232..a05fec9ad43 100644
> > --- a/dlls/mfplat/mediatype.c
> > +++ b/dlls/mfplat/mediatype.c
> > @@ -1380,6 +1380,7 @@ static const WAVEFORMATEX * WINAPI
> > audio_mediatype_GetAudioFormat(IMFAudioMediaT>
> >               &size, MFWaveFormatExConvertFlag_Normal)))
> >   {
> >
> >       WARN("Failed to create wave format description, hr %#lx.\n",
> >       hr);
> >
> > -
> >    media_type->audio_format = 0;
> >
> > }
>
> This makes sense, but let's reset it after CoTaskMemFree(), and use NULL
> as it's more common for null pointers. Same issue with GetVideoFormat().

Thanks for your comments, I'll resend soon.

Regards,
Fabian Maurer