Re: msi: Install Entire Feature

[James Hawkins]

On 11/18/07, Daniel Sim  wrote:
> "Install entire feature" enabled and implemented.

What is this patch for?  Is this to fix a bug?

+    /* FIXME: Why 0x1000? */

Don't add random comments about things you don't understand in the code.

+msi_seltree_install_entire_feature(HWND hwnd, HTREEITEM hItem,
MSIPACKAGE *package, UINT r) {

Please use the style of the rest of the file (bracket below function).

+    for (
+    child = TreeView_GetChild (hwnd, hItem);
+    child;
+    child = TreeView_GetNextSibling (hwnd, child) )

Style changed again...and that's just ugly.

+        msi_seltree_install_entire_feature (hwnd, child, package, r);

Why are you doing this recursively?