Alexandre Julliard julliard@winehq.org wrote:
Jacek Caban jacek@codeweavers.com wrote:
I'm not sure I agree.
Please don't get me wrong, but when sending tests after the fixes the result can't be easily verified, and therefore this reduces the trust and value of patches.
There are many cases where adding todos and then removing them creates more work, so it's perfectly acceptable to send a test to apply after the fix to demonstrate that it is correct. We do that all the time.
In this case just adding and then removing TRUE in ok_sequence() call and adding and then removing appropriate todo_wine statements shouldn't create too much additional work, after all this work should be done anyway in order to verify that the patch actually works.
If you don't trust that the test is testing the right thing, it's easy enough to verify by reverting the fix and confirming that the test fails. I do that frequently myself.
As I have said, the patches that remove todo_wine statements are easier recognizable as the fixes.