On Thu, Jan 23, 2020 at 12:27 PM Stefan Dösinger stefandoesinger@gmail.com wrote:
Am 23.01.20 um 18:33 schrieb Jeff Smith:
- if (hal_caps.ddsCaps.dwCaps && (~hal_caps.ddsCaps.dwCaps & caps_always))
- {
skip("Failed to find sufficient hardware caps, skipping test.\n");IDirectDraw_Release(ddraw);return;- }
On which machine do you get test failures otherwise? Can you test https://source.winehq.org/patches/data/176979 and see if that helps too? Patch 176980 may be relevant too.
There are certainly some other weird things going on in the test that I don't fully understand yet.
Hi Stefan,
IIRC, on the testbot machine using the "WMware SVGA II" driver, the HAL caps include DDSCAPS_FLIP, DDSCAPS_OFFSCREENPLAIN, DDSCAPS_PRIMARYSURFACE but not DDSCAPS_TEXTURE, DDSCAPS_ZBUFFER, DDSCAPS_MIPMAP
I don't have a box set up that reports lacking these caps. Patches #1 and #3 are tied to these HAL caps: #1: if that TEXTURE flag is not set, skip a test that depends on texture support #3: if any of those flags are not set, skip the tests that relate back to those flags being set. These do seem similar to 176980 (but for different flags). I will look into doing some tests with 176979, to see if it has any impact on these flags.
As for patch #2: for VIDEOMEMORY surfaces, if the reported line pitch is unpadded, pass the test (as a "broken" value). I doubt that one is really related to the others (besides being caused by the same driver).
Thanks, Jeff