Re: [PATCH 1/3] uiribbon: Add DLL

[Alistair Leslie-Hughes]

Hi Fabian,

This is about the series of uiribbon.
> +BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv)

Since nothing is implemented in this dll, please return check for
DLL_WINE_PREATTACH. (example dlls/authz/authz.c).  In this patch
you could also add the private functions.

patch 2.
> - uiribbon.idl \

...
> interface IUIFramework : IUnknown
> +{
> -
>
> +}
> -

If your going to add a idl file, please fill in methods available for
each interface.  Please also avoid the forward declare for
IUIApplication include it in the idl as well.
> -
>
> +HRESULT UIRibbonFrameworkImpl_Create(IUnknown* pUnkOuter, LPVOID* ppObj)l;

Move this function to after
+static const IUIFrameworkVtbl IUIFramework_Vtbl =
then you wont need the forward declare.

I would have the following patches.
1. Add new dll (DLLMain and private functions)
2. Add idl to include (Including all the interfaces required)
3. Add the stubbed interface.
4. Tests? (maybe not possible at this stage).

Best Regards
 Alistair Leslie-Hughes