On Fri, Feb 12, 2021 at 9:03 PM Serge Gautherie < winehq-git_serge_180711@gautherie.fr> wrote:
Hello Alexandre,
I am looking for a reviewer for my patches...
[PATCH] wininet: Add spaces to 3 ERR() and fix 1 'escape' copypasta. https://source.winehq.org/patches/data/199448
[PATCH] comctl32/tests: Add more cases for ImageList_Remove(). https://source.winehq.org/patches/data/199500
For the second patch, I'm not sure why you had to remove some existing tests. Also there is no need to make failure messages that explicit:
"Removed nonexistent item 1 from NULL handle\n"
Obviously nothing was removed, because there is no list to remove from.
+ ok(!pImageList_Remove(himl, 3), "Removed nonexistent item 3\n"); + ok(!pImageList_Remove(himl, -2), "Removed nonexistent item -2\n");
Same here, differences in return value does not mean item that does not exist was removed. Item -2 can't exist in a first place.
Thanks.
--