Re: [PATCH v2 06/10] ddraw/tests: Run test_depth_blit() for each device type.

[Henri Verbeet]

On Tue, 9 Mar 2021 at 10:57, Paul Gofman  wrote:
>  hr = IDirect3DViewport2_Clear(viewport, 1, &d3drect, D3DCLEAR_ZBUFFER | D3DCLEAR_TARGET);
> - ok(SUCCEEDED(hr), "Failed to clear the color and z buffers, hr %#x.\n", hr);
> - ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr);
> -

Not a big deal, but since you're changing these: D3D interfaces would
return D3D_OK.
> - color = get_surface_color(rt, 80, 60);
> - /* For some reason clears and colour fill blits randomly fail with software render target. */
> - ok(color == 0x00ff0000 || broken(is_software_device_type(device_guid) && !color),
> -
>        "Got unexpected colour %#x.\n", color);
> - if (!color)
> - {
> -
>    fill_surface(rt, 0xffff0000);
> -
> -
>    color = get_surface_color(rt, 80, 60);
> -
>    ok(color == 0x00ff0000, "Got unexpected colour %#x.\n", color);
> - }

Here, and in a few other places in this series: "0x%08x" for colours, please.