On 10/3/16 2:05 PM, Sebastian Lackner wrote:
On 03.10.2016 17:27, Aric Stewart wrote:
On 10/3/16 6:29 AM, Sebastian Lackner wrote:
From: Aric Stewart aric@codeweavers.com
Signed-off-by: Aric Stewart aric@codeweavers.com Signed-off-by: Sebastian Lackner sebastian@fds-team.de
Second part of 126774. Besides splitting, I've also done the following changes:
- Rename find_hid_device -> bus_find_hid_device, for consistency with other bus_*_hid_*() functions.
- Do not append timestamp to the device names. To make the code more robust, I've modified bus_remove_hid_device() to defer the release of the pnp_device pointer. If there are more problems I would prefer to fix them properly, adding the timestamp seems more like a hack to me.
- Some style improvements.
@Aric: I'm not sure if you are aware of it, but there is currently still a bug somewhere which causes a crash during RemovalRelations when trying to remove a driver which was never added properly. I feel like the right place to fix that is somewhere in ntoskrnl. Are you aware of this issue?
Yes, that bug is fixed by patch 126650, which has not been reviewed or committed yet.
The patch does not help here. It also sounds like you are trying to fix a different problem because the issue I have can be reproduced without winehid/hidclass. Nevertheless, one way to improve 126650 would be to remove the unnecessary "break;" after the return.
Ahh yes, Got ahead of myself. I will try to get a chance to circle up on that and fix 126650, As for this crash I am betting it has to do with not handling the power ioctls in the base device. I will try to dig into that also when I get a chance. Traveling for the next 3 weeks so my time may be intermittent but I will try to carve out a chance to get to this.
-aric
Regards, Sebastian