Re: [PATCH 3/3] gdi32: Fix text metrics in synthetic bold bitmap fonts. (rebased)

[Akihiro Sagawa]

On Tue, 13 Feb 2018 16:25:22 +0000, Huw Davies wrote:
> > > It looks odd to me that tmOverHang gets incremented by essentially the
> > > scaling factor, yet the widths only get incremented by one.  Shouldn't
> > > these all be consistent?
> >
> > Indeed, this looks odd. However, following my test shows tmOverhang is
> > incremented only 1 (in MM_TEXT mode) neverthless scaling factor.
> > | +        ok(data[i+1].tm.tmOverhang == 1,
> > | +           "expected 1, got %d\n", data[i+1].tm.tmOverhang);
> > If tmOverhang would be affected by scalling factor, this test wouldn't
> > pass when data[3].tm.tmOverhang is evaluated.
> >
> > Moreover, my manual test shows if height == 200, the tmOverhang value is
> > still only 1 with Courier font.
>
> If I change:
>     ptm->tmOverhang += fabs(font->font_desc.matrix.eM11);
> to:
>     ptm->tmOverhang++;
>
> the tests still pass.

I see. I'll add more tests with another mapping mode to prove consistent.

Thanks pointing out that,
Akihiro Sagawa