Jon Griffiths jon_p_griffiths@yahoo.com writes:
- Is it OK to give meaningful names to undocumented functions?
e.g. SHLWAPI_1/2 => UrlGetInfoA/W SHLWAPI_5/6 => PathFindOnPathExA/W
No, this will cause major confusion. What you can do is create a SHLWAPI_UrlGetInfo internal function that is called both by SHLWAPI_1 and by other functions that need it.
- How to deal with shared undocumented functions?
e.g. StrRetToBufA/W is used by shell32, but should not defined in shlwapi.h.
Here there are 4 Choices:
- Define twice (Ugly)
- Put into a new wine/undocshlwapi.h (Seems that these are
depreciated?) 3. Define anyway (Im not a fan of having undoc functions in public headers) 4. Have shell32 functions #include "../shlwapi/internal.h" (A little unclean)
I'd like to go for 4, any objections?
3. is much better. As long as the functions are actually exported from shlwapi, there's no reason not to export the prototypes too. Besides, by being implemented in Wine they are now documented <g>