Re: [PATCH v3 1/3] ntdll: Factor out get_vprot_range_size() function.

[Paul Gofman]

On 9/20/21 21:59, Alexandre Julliard wrote:
> Paul Gofman  writes:
> > @@ -4098,7 +4117,7 @@ static NTSTATUS get_basic_memory_info( HANDLE process, LPCVOID addr,
> >                                          SIZE_T len, SIZE_T *res_len )
> >   {
> >       struct file_view *view;
> > - char *base, *alloc_base = 0, *alloc_end = working_set_limit;
> > - BYTE *base, *alloc_base = 0, *alloc_end = working_set_limit;
> >  struct wine_rb_entry *ptr;
> >  sigset_t sigset;
> >
> > @@ -4145,20 +4164,20 @@ static NTSTATUS get_basic_memory_info( HANDLE process, LPCVOID addr,
> >       while (ptr)
> >       {
> >           view = WINE_RB_ENTRY_VALUE( ptr, struct file_view, entry );
> > -
> >    if ((char *)view->base > base)
> > -
> >    if ((BYTE *)view->base > base)
> >     {
> >         alloc_end = view->base;
> >         ptr = ptr->left;
> >     }
> > -
> >    else if ((char *)view->base + view->size <= base)
> > -
> >    else if ((BYTE *)view->base + view->size <= base)
> >     {
> > -
> >        alloc_base = (char *)view->base + view->size;
> > -
> >        alloc_base = (BYTE *)view->base + view->size;
> >         ptr = ptr->right;
> >     }
> >     else
> >     {
> >         alloc_base = view->base;
> > -
> >        alloc_end = (char *)view->base + view->size;
> > -
> >        alloc_end = (BYTE *)view->base + view->size;
> >         break;
>
> That sort of change doesn't seem necessary.

Thanks, I will follow the existing path and use 'char *' in the new 
function then.