Re: [PATCH v4 1/8] reg.exe: Perform checks in wmain

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-10-09 10:55, schrieb Jonathan Vollebregt:
> Move as much error-checking to main as possible so sub functions 
> don't have to repeat basic checks
>
> IE: Is the key on a remote system, or are we missing arguments?

I don't think this is really an improvement. The old code first looked
at argvW[1], then argvW[2], ..., with clear checks that the argument
count is big enough. The new code jumps around between the arguments
without any clear order. As a result it still isn't clear if argv[2]
is supposed to be a registry key at all when you check it for
remoting. While it may be true in the current form of reg.exe, it
won't work if support for e.g. reg import is added.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUOoBfAAoJEN0/YqbEcdMw+ogP/AnFEAMDQrGtrjtau/EL0Yuu
vkmUcgAcSG71I//iFchLvpSzzrVlgmrX2t8eatFHyClBh0jhGwtFOvdXHiilsOEV
yRcJBlkr5wa+hD+SvpBX4VGTBFJEhbJ9uhzzeFv0teh6AhxVpkjFGM6yR373xmkz
Pk9F7sT30YxOqF5RftPwWylihpWNOgMwk2rHJkanImI+Fle0EMQOIaI+ASDsc5i0
DhAl8Xs867wUkiFfBzU5l5p+nARGr971PDj3nUOubDeJEUNBaO7d+Uh4AAa9a+h3
evDd1e+kdW8kjStnFXQZfkFYw+8gK9lxB05NrX1EeIkGoxpKaOXMW+5gEV76eb8z
yqfe3vdzijHptKGxAml5Y6A7N3HPuZyi+dwDW41Dmgsz3cY+WmZ6X3CGXB3wBcew
SVSoZjfcdE4mq6BDFPRC7A1+Rt6aYUAvxQDQT+jhRtlMBRQrAtML3o9n08JEbqkD
T6twKYBniWHBlGgb8rD9yA1snUYlOO2a4zhGzZ2Z/L9WHMzxOXLApa2x6Tcew9Jz
V1gqDQPpgwhy4a/8oeukwj9VH2uva12Q72f7RQMKc1Q7CGXskso4RlZpJpHi2eNi
1oHDQzTYX0nLOSeU8C4336zq+ljh2Csme8CtLFw9a44mbzhSzzdtWJBcS3M8pQ8C
Txkl4Xka006+rZQHjzQO
=inoY
-----END PGP SIGNATURE-----