On 28/07/2020 16:21, Stefan Dösinger wrote:
Am 28.07.2020 um 15:06 schrieb Gabriel Ivăncescu gabrielopcode@gmail.com:
On 28/07/2020 13:32, Stefan Dösinger wrote:
Am 27.07.2020 um 20:53 schrieb Gabriel Ivăncescu <gabrielopcode@gmail.com mailto:gabrielopcode@gmail.com>:
if (GetForegroundWindow() != window) return DDERR_WRONGMODE;For the purpose of my understanding: is window != NULL here when Railroad Tycoon 2 hits this codepath?
When it hits this codepath, window == dest_window, since it never sets focuswindow (so it's NULL).
It's not NULL, though, it's the game's window. dest_window can't be NULL, right?
It can be NULL in DDSCL_NORMAL, but then you wouldn't hit the focus loss codepath yeah. That's just from the top of my head, I can't rule out that there are more weird cases where it is NULL. ddraw is weird :-)
Yeah, I'll just add a check for NULL just to be safe.