On 11/30/21 2:14 PM, rbernon@codeweavers.com wrote:
On 11/30/21 1:26 PM, Jacek Caban jacek@codeweavers.com wrote:
Also preserve last error.
FWIW I think I had similar problems with my nulldrv patches, and the last error reset comes from CreateMutex. If you plan on using ntdll functions directly (or if you don't, using them would), it should not be necessary to save and restore last error.
The assumption that SetupAPI calls preserve last error seems questionable to me. Anyway, my plan is to move all update_monitor_cache callers to win32u and use the cache introduced by this series. I have update_monitor_cache removed in my tree and I plan to send a series doing that soon after this one. I just used a quick and non-invasive solution here for now.
Thanks,
Jacek