Re: [PATCH vkd3d v2 4/6] vkd3d-shader/hlsl: Flatten initializers.

[Zebediah Figura (she/her)]

On 2/22/22 16:13, Francisco Casas wrote:
> @@ -1583,14 +1699,14 @@ static struct list *declare_vars(struct hlsl_ctx *ctx, struct hlsl_type *basic_t
>               {
>                   unsigned int initializer_offset = 0;
> -
>            if (v->initializer.args_count != size)
> -
>            if (!flatten_parse_initializer(ctx, &v->initializer))
>             {
> -
>                hlsl_fixme(ctx, &v->loc, "Flatten initializer.");
> -
>                hlsl_fixme(ctx, &v->loc, "Could not flatten initializer.");

We should only return false here if we failed to allocate memory; no 
need to hlsl_fixme().
>                   free_parse_initializer(&v->initializer);
>                   vkd3d_free(v);
>                   continue;
>               }