RE: New valgrind warnings in wined3d/arb_program_shader.c

[Stefan Dösinger]

Does the attached patch fix the warnings?
> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] On
> Behalf Of Dan Kegel
> Sent: Thursday, July 31, 2008 12:22 PM
> To: wine-devel
> Cc: Stefan Dösinger
> Subject: New valgrind warnings in wined3d/arb_program_shader.c
>
> Hi Stefan,
> your recent round of changes (circa
> http://www.winehq.org/pipermail/wine-cvs/2008-July/045946.html)
> seems to have triggered a whole bunch of valgrind warnings, e.g.
>
> http://kegel.com/wine/valgrind/logs/2008-07-31-07.46/vg-d3d9_visual-
> diff.txt
> - Use of uninitialised value of size 4
> - at  hash_table_get_by_idx (utils.c:1600)
> - by  hash_table_get (utils.c:1750)
> - by  find_ffp_shader (utils.c:1961)
> - by  fragment_prog_arbfp (arb_program_shader.c:2761)
> - by  ActivateContext (context.c:1169)
> - by  drawPrimitive (drawprim.c:950)
> - by  IWineD3DDeviceImpl_DrawIndexedPrimitiveUP (device.c:5350)
> - by  IDirect3DDevice9Impl_DrawIndexedPrimitiveUP (device.c:1227)
> - by  lighting_test (visual.c:300)
> - by  func_visual (visual.c:9234)
> - by  run_test (test.h:488)
> - by  main (test.h:537)
> - Uninitialised value was created by a stack allocation
> - at  fragment_prog_arbfp (arb_program_shader.c:2745)
>
> http://kegel.com/wine/valgrind/logs/2008-07-31-07.46/vg-ddraw_visual-
> diff.txt
> - Use of uninitialised value of size 4
> - at  hash_table_get_by_idx (utils.c:1600)
> - by  hash_table_get (utils.c:1750)
> - by  find_ffp_shader (utils.c:1961)
> - by  fragment_prog_arbfp (arb_program_shader.c:2761)
> - by  ActivateContext (context.c:1169)
> - by  drawPrimitive (drawprim.c:950)
> - by  IWineD3DDeviceImpl_DrawIndexedPrimitiveUP (device.c:5350)
> - by  IDirect3DDeviceImpl_7_DrawIndexedPrimitive (device.c:3731)
> - by  IDirect3DDeviceImpl_7_DrawIndexedPrimitive_FPUSetup
>
> (device.c:3754)
> - by  lighting_test (visual.c:276)
> - by  func_visual (visual.c:2649)
> - by  run_test (test.h:488)
> - by  main (test.h:537)
> - Uninitialised value was created by a stack allocation
> - at  fragment_prog_arbfp (arb_program_shader.c:2745)
>
> Could you have a look?
>
> Thanks,
> Dan