10 Jun
2022
10 Jun
'22
10:51 a.m.
On Fri Jun 10 10:46:28 2022 +0000, **** wrote:
Henri Verbeet replied on the mailing list:
On Fri, 10 Jun 2022 at 12:34, Jan Sikorski (@jsikorski) <wine@gitlab.winehq.org> wrote: > > Jan Sikorski (@jsikorski) commented about dlls/d3d11/texture.c: > > return S_OK; > > } > > > > - if (texture->dxgi_surface) > > + if (texture->dxgi_resource) > Mostly to test my understanding, do we still actually need to check this for some reason? I think we should be able to drop the check and do this unconditionally. That would apply to e.g. d3d_texture1d_wined3d_object_released() as well.
I'm not sure about the released() procedures - it looks like if we fail to create the dxgi_resource, we decref the texture or buffer and then it gets released with dxgi_resource set to NULL, no?