On Sat, 20 Oct 2018 at 02:39, Ken Thomases ken@codeweavers.com wrote:
On Oct 19, 2018, at 2:07 PM, Alexandre Julliard julliard@winehq.org wrote:
Henri Verbeet hverbeet@gmail.com writes:
On Fri, 19 Oct 2018 at 19:51, Henri Verbeet hverbeet@gmail.com wrote:
I think I missed a step there... why is copying the code into the Wine tree a given? Does FNA not provide an API for external users?
Actually, I read over that mail a little to quickly, and missed the second option, so ignore that reply.
Perhaps unsurprisingly, I'm in favour of having FNA be a proper library with a stable API that Wine can link against like everyone else.
Yes, clearly this would be the preferred approach.
Is there any need/desire/benefit for XAudio2 to go through the other Windows audio APIs (e.g. MMDevAPI, WASAPI) for proper integration? Coherent enumeration of devices? Audio mixing from different APIs? Client control of audio devices? User control via winecfg or the registry?
Potentially, I think, but I also think it's a somewhat orthogonal issue. I.e., similar to how you can put the library's user in control of memory allocation, you can also do that for things like device enumeration, configuration management, etc. You need to come up with good interfaces for that, but I don't think it should be a factor for whether to "vendor" the code into the Wine tree or not.