Re: [PATCH] wincodecs: Add IWICImagingFactory2 stub.

[Nikolay Sivov]

On 09/30/2018 07:14 AM, Dmitry Timoshkov wrote:
> Nikolay Sivov  wrote:
> > static const classinfo wic_classes[] = {
> >       {&CLSID_WICImagingFactory, ComponentFactory_CreateInstance},
> > - {&CLSID_WICImagingFactory2, ComponentFactory_CreateInstance},
> >  {&CLSID_WICBmpDecoder, BmpDecoder_CreateInstance},
> >  {&CLSID_WICPngDecoder, PngDecoder_CreateInstance},
> >  {&CLSID_WICPngEncoder, PngEncoder_CreateInstance},
> >
> > diff --git a/dlls/windowscodecs/imgfactory.c b/dlls/windowscodecs/imgfactory.c
> > index 06e3f6aceb..f23c824473 100644
> > --- a/dlls/windowscodecs/imgfactory.c
> > +++ b/dlls/windowscodecs/imgfactory.c
> > @@ -37,6 +37,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(wincodecs);
> >
> > typedef struct {
> >       IWICComponentFactory IWICComponentFactory_iface;
> > - IWICImagingFactory2 IWICImagingFactory2_iface;
> >  LONG ref;
> > } ComponentFactory;
>
> IWICImagingFactory2 just extends IWICImagingFactory by one element, this
> approach seems to be a bit strange.

Both IWICComponentFactory andIWICImagingFactory2extend IWICImagingFactory.