Re: [PATCH] [d3dx9]: Add D3DXComputeTangentFrame implementation

[Vijay Kiran Kamuju]

Hi Matteo,

On Tue, Dec 5, 2017 at 8:47 PM, Matteo Bruni  wrote:
> 2017-12-01 11:20 GMT+01:00 Vijay Kiran Kamuju :
> > +/*************************************************************************
> > -
> > - D3DXComputeTangentFrame    (D3DX9_36.@)
> > - */
>
> That header is unnecessary, I'd get rid of it.

Ok.
> > +HRESULT WINAPI D3DXComputeTangentFrame(ID3DXMesh *mesh, DWORD options)
> > +{
> > - TRACE("mesh %p, options %#x\n", mesh, options);
>
> Please put a period at the end of the message.

Ok.
> > -
> > - return D3DXComputeTangentFrameEx(mesh, D3DDECLUSAGE_TEXCOORD, 0,
>
> Trailing whitespace (Gmail will most likely eat it but it's there in
> the actual patch)
> > -
> >        D3DDECLUSAGE_BINORMAL, 0, D3DDECLUSAGE_TANGENT, 0, D3DDECLUSAGE_NORMAL, 0,
> > -
> >        options | D3DXTANGENT_GENERATE_IN_PLACE,
> > -
> >        NULL, 0.01f, 0.25f, 0.01f, NULL, NULL);
>
> I think we want some tests, at the very least to confirm that those
> are the correct arguments.

I have used below MSDN docs :
https://msdn.microsoft.com/en-us/library/windows/desktop/bb172744(v=vs.85).a...
Do we still need tests?