Re: [PATCH] vbscript: Fixed CBool(try 2)

[Jacek Caban]

On 05/01/14 16:38, Piotr Caban wrote:
> > These are the failing tests:
> > Call testCBoolError("#TRUE#", 458)
> > Call testCBoolError("#FALSE#", 458)
> > Call testCBoolError(MyObject, 458)
>
> In order to fix it you need to change the implementation. Probably you
> need to check if string equals to "#TRUE#" and return early without
> calling VariantChangeType. I'm not sure what needs to be done in
> MyObject case.

Actually, I'd like to see a cleaner solution than special casing
specific strings.

Jacek