Re: [PATCH] d3dx10: Implement D3DX10CreateDeviceAndSwapChain

[Matteo Bruni]

2016-08-02 9:48 GMT+02:00 Alistair Leslie-Hughes :
> - TRACE("adapter %p, driver_type %d, swrast %p, flags %#x, desc %p, swapchain %p, device %p\n",
> -
>        adapter, driver_type, swrast, flags, desc, swapchain, device);

Missing period at the end of the trace message.
> - if (SUCCEEDED(hr = D3D10CreateDeviceAndSwapChain1(adapter, driver_type, swrast, flags, D3D10_FEATURE_LEVEL_10_1,
> -
>        D3D10_1_SDK_VERSION, desc, swapchain, (ID3D10Device1 **)device)))
> -
>    return hr;
> -
> - if (SUCCEEDED(hr = D3D10CreateDeviceAndSwapChain1(adapter, driver_type, swrast, flags, D3D10_FEATURE_LEVEL_10_0,
> -
>        D3D10_1_SDK_VERSION, desc, swapchain, (ID3D10Device1 **)device)))
> -
>    return hr;
> -
> - return hr;
>
> +}

The second if is redundant, you're going to "return hr;" either way.