Re: [PATCH 3/5] wined3d: Properly allocate heap memory for volumes

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-08-19 12:31, schrieb Henri Verbeet:
> On 19 August 2013 10:52, Stefan Dösinger 
> wrote:
> > @@ -184,7 +184,16 @@ HRESULT CDECL wined3d_volume_map(struct
> > wined3d_volume *volume, volume, map_desc, box, flags);
> >
> > if (!volume->resource.allocatedMemory) -
> > volume->resource.allocatedMemory = HeapAlloc(GetProcessHeap(),
> > HEAP_ZERO_MEMORY, volume->resource.size);
>
> Can this ever happen?

I think not, but I am not certain of this. The allocation will be
needed after patch 13 though, so after the patches the end result is
the same. Since the HeapAlloc call is there right now I prefer to keep
it instead of possibly introducing temporary regressions.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSEgTiAAoJEN0/YqbEcdMw5uYP/R7nU/V7EoixfVx/QwbfgkD+
mUc9+8U/jxRmbLxOct2M4GG4B0V17XdQHxaeSLIDG1LKBkEtnBrTUf5ticEvq3Ne
K8TCQoYPvlY6EHLeN6uFtY7Ps2JPnK+PQ9Rb+trj3vWiT0VUmsEgwFt2dAU0/s47
aB6Hhm4AkH2EoZJJdZFTsM3B4sI75wzyyOH31H1HchmOcruK/O42Ee5b+2NgcdUM
aSPIgfpQaTw3ccWbAlZUAywJhKwANFtdOOfsrdVUm9UCYKQKOYBdo3i74pbK4WqV
97DJ9oyCXjayys7cORqJWRa9d4nQ3pldQ4vRxEI5YCHJAffcpTtff/veiL3lfG5t
5ilvTkn1pRMSHIQ4q26p68N9ixcku9sR3shNExJuLzXgwAwoBEQ+qnjF5p7YVuUW
5z/JueDl2t9XOfJHW2Uvuuc5ir+HFcU88BxgXBlp3q4F7yjvPZgivwn4zgQ7pnTU
LQPZSD5kIYbV2IvB5sRcn7M33mr2vNEiqiRSrHy0FPY4bWLVGVru4evKWMRA5wmk
JEZJP/zk3cF3zWBPhFxcdUZC0NASv1Ys4qUCgr+Nv28bjVTrN9BTlCuCxLp10uUi
hpMpb5WIf+YUJWVX9G6IcK+pypWwJmwnVkA3ZQkFs+oxOnjMzsC1YD1Ut0zDEqdM
oiR7kxJRRapou6oluPb0
=yK7D
-----END PGP SIGNATURE-----