Re: [PATCH 3/3] iphlpapi: Implement ParseNetworkString for IPv6 addresses and services

[Alex Henrie]

On Wed, Mar 18, 2020 at 11:06 PM Nikolay Sivov  wrote:
> On 3/19/20 6:06 AM, Alex Henrie wrote:
> > - if (type & NET_STRING_IPV6_ADDRESS)
> > - {
> > -
> >    status = RtlIpv6StringToAddressExW(str, &temp_addr6, &temp_scope, &temp_port);
> > -
> >    if (SUCCEEDED(status) && !temp_port)
> > -
> >    {
>
> NTSTATUS is usually checked for 0 aka STATUS_SUCCESS.

Hmm, ParseNetworkString already has code that uses the SUCCEEDED macro
instead of checking specifically for STATUS_SUCCESS. If Alexandre
rejects the patch over it, I'll resend and correct all four uses of
SUCCEEDED at the same time.

-Alex