-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Am 2015-10-15 um 21:54 schrieb Bernhard Übelacker:
hr = IDirect3DRM3_CreateDeviceFromClipper(d3drm, pClipper, &driver, rc.right, rc.bottom, &device); ok(hr == D3DRM_OK, "Cannot get IDirect3DRMDevice interface (hr = %x)\n", hr);
- if (FAILED(hr))
- {
skip("Cannot get IDirect3DRMDevice interface (hr = %x), skipping tests\n", hr);IDirectDrawClipper_Release(pClipper);IDirect3DRM_Release(d3drm);DestroyWindow(window);return;- }
The test will fail regardless, so you don't gain too much. It would be nicer if the test skips without a failing ok() statement in this case.
Do you have a Windows VM to test how native d3drm responds if d3d is not available? I.e., which error code is returned? It might be a bit tricky to test because we request a software device that Wine doesn't implement but should be available everywhere on Windows. If you need help finding that out I can play a bit with my Windows XP box.
(Technically failing is correct because we should have a software device without host GL in theory, but I don't expect that we'll ever implement one, so I think not failing the test if GL isn't available is the best thing to do)